Address Copilot CI feedback from #23 - #24
Closed
slashrsm wants to merge 3 commits into
Closed
Conversation
- Raise php requirement to >=8.2 to match tested matrix - Cache Composer download cache instead of vendor/ - Enable sqlite3 and mongodb extensions - Drop broad --ignore-platform-req=\"ext-*\" - Validate lock when present; hash lock in cache key
There was a problem hiding this comment.
Pull request overview
This PR updates project/CI requirements and Composer caching to align with the PHP 8.2–8.5 CI matrix and improve dependency install performance/reliability when using composer update without a lockfile.
Changes:
- Bump the Composer PHP requirement to
>=8.2. - Update CI to cache Composer’s download cache (instead of
vendor/) and includecomposer.lockin the cache key when present. - Adjust CI to enable
sqlite3andmongodbextensions and stop ignoring allext-*platform requirements.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Raises the minimum PHP version to match the CI matrix baseline. |
| .github/workflows/test.yml | Improves Composer validation and caching; enables required PHP extensions and removes broad platform-req ignores. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use ^8.2 instead of >=8.2 so Composer does not accept PHP 9+ by default - Prefer composer install when a lockfile is present
- Pass --no-interaction on composer validate/install/update - Rename validate step to reflect lockfile handling
slashrsm
added a commit
that referenced
this pull request
Jul 22, 2026
Contributor
Author
|
Merged to master via git squash (gh OAuth lacks workflow scope for PR merge API). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #23 addressing Copilot review comments.
phprequirement to^8.2to match the CI matrixvendor/sqlite3andmongodbextensions--ignore-platform-req="ext-*"composer installwhen lock present--no-interactionTest plan