Skip to content

Address Copilot CI feedback from #11 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slashrsm wants to merge 3 commits into from
Closed

Address Copilot CI feedback from #11 #12

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb130aa
Address Copilot CI feedback from #11
slashrsm Jul 22, 2026
43acb9c
Apply additional Copilot feedback on PHP constraint and install
slashrsm Jul 22, 2026
d033b73
CI polish from Copilot: non-interactive Composer, clearer step name
slashrsm Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,28 @@ jobs:


- name: Validate composer.json
run: composer validate --strict --no-check-lock
run: |
if [ -f composer.lock ]; then
composer validate --strict
else
composer validate --strict --no-check-lock
fi
Comment on lines +34 to +38

- name: Cache Composer packages
uses: actions/cache@v4
with:
path: vendor
key: ${{ runner.os }}-composer-${{ matrix.php-versions }}-${{ hashFiles('**/composer.json') }}
key: ${{ runner.os }}-composer-${{ matrix.php-versions }}-${{ hashFiles('**/composer.json', '**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-${{ matrix.php-versions }}-

- name: Install dependencies
run: composer update --prefer-dist --no-progress
run: |
if [ -f composer.lock ]; then
composer install --prefer-dist --no-progress
else
composer update --prefer-dist --no-progress
fi

- name: Run test suite
run: vendor/bin/phpunit
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"docs": "https://portphp.readthedocs.org"
},
"require": {
"php": "^8.2",
"portphp/portphp": "^1.6.0"
},
"autoload": {
Expand Down
Loading