Fix line ending check on Windows for .properties files#5671
Open
armahnii2000 wants to merge 1 commit intoportfolio-performance:masterfrom
Open
Fix line ending check on Windows for .properties files#5671armahnii2000 wants to merge 1 commit intoportfolio-performance:masterfrom
armahnii2000 wants to merge 1 commit intoportfolio-performance:masterfrom
Conversation
The check-managed-bundles build step requires LF line endings on .properties files. On Windows clones with the default core.autocrlf=true, Git converts these files to CRLF on checkout, breaking the build. Pinning eol=lf in .gitattributes forces Git to always check out .properties files with LF regardless of OS or autocrlf setting. Closes portfolio-performance#5670
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitattributesdoesn't pin*.propertiesto LF, so on Windows (wherecore.autocrlf=trueis the default) Git checks them out as CRLF andcheck-managed-bundlesrejects them.Verified on Windows 11 with
clean verify -Plocal-dev.Existing Windows clones will need to refresh after pulling:
Closes #5670