Improvement: Value colour scheme improvements#5579
Improvement: Value colour scheme improvements#5579georgemac-labs wants to merge 3 commits intoportfolio-performance:masterfrom
Conversation
- Use ColoredLabel with setTextColor/setBackdropColor instead of plain Label with setForeground, which was being overridden by the dark mode CSS theme engine - Set DISABLE_CSS_STYLING on all preview widgets to prevent the theme from clobbering manually set colors - Compute preview background based on the selected theme (not the currently active one) so the preview accurately reflects how colors will appear after applying
Yes, but... The text colors differ between dark and light mode. Now the preview is changing the background, but still uses the text color from the current theme. I think this is not given the right impression. The "blue text color" of the light theme does not work with the dark background color. Unfortunately, the text color is not directly available because it is injected into the ValueColorScheme when the theme is chanted. But maybe there are ways to read the color values and apply them to the text widget? Otherwise I think it is okay to see the preview only for the current theme (light/dark) because this is what the user is using.
Me neither. For me, the bright green in the vivid light color scheme is hard to read. I am also okay to add another 4th scheme. I would need very good arguments to add a fifth. |
|
Claude says there is no easy way to get the CSS colors of the text. It recommends parsing the CSS. I am not sure it is worth the effort (and future maintenance).
|
Like approx 1 in 25 people worldwide, I have (minor) issues with shades of red and green!
The standard value colour scheme in PP is not good for me. The tones are dull, colours are recognisable if I look carefully, but you don't get the intended UI benefit of recognising them at a glance. And I am a mild case: many people would not be able to recognise the coloration at all!
Thus this PR:
TBD: