add bold to treemap label#5568
Open
mierin12 wants to merge 1 commit intoportfolio-performance:masterfrom
Open
Conversation
Member
|
Nice addition. But I think we should not create the bold font in every drawRectangle function. I think it is a fairly expensive operation.
I think it is good practice to leave the graphics context as it was received, i.e. set back the default font. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is a proposition to add bold to the security name in TreeMap.
In the tooltips of Donut and Pie Chart they are already in bold, so I thought it looks more consistent.
Before :

After :

I assumed there would always be two lines of label at least, so
setFont(defaultFont)is always called in the different loops, so no need to set it again after the loops. but maybe it would have been safer ?