PDF Extractor for Oberbank documents by iAppDeveloper88 · Pull Request #5559 · portfolio-performance/portfolio

iAppDeveloper88 · 2026-03-08T19:09:03Z

Started working on issue #5548
So far buy and sell documents are working. I would appreciate a short feedback if the implementation is OK before i continue with the other documents.
This is just a draft, so I did not check formatting and comments too much.

gamue

Thanks for contributing. I added a few comments from what I know that should be adjusted.

Personally think it'll be fine to merge the new extractor step-by-step, however I'm not a team-member, so not my decision ;)

gamue · 2026-03-08T19:46:29Z

...lio.tests/src/name/abuchen/portfolio/datatransfer/pdf/oberbank/OberbankPDFExtractorTest.java

+        new AssertImportActions().check(results, "EUR");
+
+        // check security
+        var security = results.stream().filter(SecurityItem.class::isInstance).findFirst()


this is the old assertion style, please use the newer one. See https://github.com/portfolio-performance/portfolio/blob/master/CONTRIBUTING.md#pdf-importers for an example. You can also check other (recent) tests-methods e.g. in Scalable

gamue · 2026-03-08T19:47:45Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

+
+        var pdfTransaction = new Transaction<BuySellEntry>();
+
+        // var firstRelevantLine = new


please remove not necessary comments

gamue · 2026-03-08T19:48:38Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

+                        })
+
+                        // Is type --> "Verkauf" change from BUY to SELL
+                        .section("type").optional() //


is that really optional?

gamue · 2026-03-08T19:50:20Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

+                                        // Wertpapiernummer Bezeichnung Nominale/Stück
+                                        // CA09228F1036 BlackBerry Ltd. Zugang Stk .              14,00
+                                        // Registered Shares o.N.
+                                        // Kurs 19,098 EUR Kurswert EUR              267,37


think this line isn't necessary for the security, or?

gamue · 2026-03-08T19:50:59Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

+                                        section -> section //
+                                                        .attributes("isin", "name", "nameContinued", "local", "shares") //
+                                                        .find("^Wertpapiernummer Bezeichnung Nominale/St.ck$") //
+                                                        .match("^(?<isin>[A-Z]{2}[A-Z0-9]{9}[0-9]) (?<name>.*) (Zugang|Abgang) (?<local>Stk)\\s*\\.\\s+(?<shares>[\\.,\\d]+)$") //


maybe add Abgang to the comment above as well as example

gamue · 2026-03-08T19:53:26Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

+                                        // Kurs 19,098 EUR Kurswert EUR              267,37
+                                        // @formatter:on
+                                        section -> section //
+                                                        .attributes("isin", "name", "nameContinued", "local", "shares") //


please see other extractors (like ScalableCapitalPDFExtractor). It's important to have the sections split in the same way, even that adds code-duplication. shares should be it's own section

I had it like that first but I changed it as it looked so wrong ignoring shares in this regex just have to the exact same one again for it. But I understand that its important for consistency.

gamue · 2026-03-08T19:54:38Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

+
+                        // @formatter:off
+                        // Kupon 4,55 % jährlich Stückzinsen f. 166 Tage EUR              165,55
+


unnecessary blank line

iAppDeveloper88 · 2026-03-09T06:59:57Z

I think it would make sense to merge a first version as soon as all the single transaction documents are done. I don't think it will take that long to finish that anyway.

iAppDeveloper88 · 2026-03-09T19:52:34Z

I just noticed that there is already a DreiBankenEDVPDFExtractor. Oberbank is part of the "3-Banken-Gruppe", but this PDFExtractor is only covering BKS Bank.
Should the logic for Oberbank be included in DreiBankenEDVPDFExtractor instead of creating a new PDFExtractor as the documents are very similar (but not identical)?

gamue · 2026-03-09T21:34:21Z

Die „3 Banken Gruppe“ besteht mit Oberbank, BTV Vier Länder Bank AG und BKS Bank aus drei selbstständigen und unabhängigen Regionalbanken. Die 3 Banken sind im Verbund in allen österreichischen Bundesländern und im angrenzenden Ausland aktiv.

They sound to be independent. There are similar cases already like Audi-Bank and Volkswagen-Bank, which have connections and use similar patterns. however they might split in the future or similar, so better to keep it as own classes imo.
Maybe even rename the other one to BksBank when you say it's just for this atm

Nirus2000

Hello,
my comments to this importer
rename the importer to OberbankAG.....

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

Nirus2000 · 2026-03-11T11:33:52Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankAGPDFExtractor.java

+                                        section -> section //
+                                                        .attributes("isin", "name", "nameContinued") //
+                                                        .match("^(?<isin>[A-Z]{2}[A-Z0-9]{9}[0-9]) (?<name>.*) (Zugang|Abgang) Stk\\s*\\.\\s+[\\.,\\d]+$") //
+                                                        .match("^(?<nameContinued>.*)$") //
+                                                        .assign((t, v) -> {
+                                                            t.setSecurity(getOrCreateSecurity(v));
+                                                        }),
+                                        // @formatter:off
+                                        // Wertpapiernummer Bezeichnung Nominale/Stück
+                                        // AT000B127337 Oberbank AG Zugang EUR            8.000,00
+                                        // Nachr. Anleihe 2023-2031
+                                        // @formatter:on
+                                        section -> section //
+                                                        .attributes("isin", "name", "nameContinued") //
+                                                        .match("^(?<isin>[A-Z]{2}[A-Z0-9]{9}[0-9]) (?<name>.*) (Zugang|Abgang) [A-Z]{3}\\s+[\\.,\\d]+$") //
+                                                        .match("^(?<nameContinued>.*)$") //
+                                                        .assign((t, v) -> {
+                                                            t.setSecurity(getOrCreateSecurity(v));
+                                                        }))


Missing currency to create a security ... see getOrCreateSecurity function

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

Nirus2000 · 2026-03-11T11:42:22Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankAGPDFExtractor.java

+    private void addDeliveryInOutBoundTransaction()
+    {
+        final var type = new DocumentType("(Durchf.hrungsanzeig\\s*e\\s+" //
+                        + "(Freier Erhalt" //
+                        + "|Freie Lieferung))");
+        this.addDocumentTyp(type);
+
+        var pdfTransaction = new Transaction<PortfolioTransaction>();
+
+        // Delivery inbound and outbound documents have multiple pages. The
+        // first two start with the same line,
+        // e.g.: Durchführungsanzeig e Freier Erhalt
+        //
+        // Repeated occurrences must be ignored to prevent the creation of
+        // duplicate blocks.
+        var startsWith = Pattern.compile("^Durchf.hrungsanzeig\\s*e\\s+(Freie Lieferung|Freier Erhalt)$");
+        var splittingStrategy = (SplittingStrategy) lines -> {
+            var blockIdentifiers = new HashSet<String>();
+
+            // first: find the start of the blocks
+            var blockStarts = new ArrayList<Integer>();
+
+            for (var ii = 0; ii < lines.length; ii++)
+            {
+                var matcher = startsWith.matcher(lines[ii]);
+                if (matcher.matches() && blockIdentifiers.add(lines[ii]))
+                    blockStarts.add(ii);
+            }
+
+            // second: convert to line spans
+            var spans = new ArrayList<LineSpan>();
+            for (var ii = 0; ii < blockStarts.size(); ii++)
+            {
+                int startLine = blockStarts.get(ii);
+                var endLine = ii + 1 < blockStarts.size() ? blockStarts.get(ii + 1) - 1 : lines.length - 1;
+                spans.add(new LineSpan(startLine, endLine));
+            }
+            return spans;
+        };


Nope... look at other importers to fix this problem.
See .rangeAs or in the document class

Nirus2000 · 2026-03-11T11:42:43Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankAGPDFExtractor.java

+                        .section("isin", "name", "nameContinued") //
+                        .match("^(?<isin>[A-Z]{2}[A-Z0-9]{9}[0-9]) (?<name>.*) (Zugang|Abgang) Stk\\s*\\.\\s+[\\.,\\d]+$") //
+                        .match("^(?<nameContinued>.*)$") //
+                        .assign((t, v) -> {
+                            t.setSecurity(getOrCreateSecurity(v));
+                        })


Missing currency

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankAGPDFExtractor.java

Nirus2000 · 2026-03-11T11:43:36Z

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OberbankPDFExtractor.java

+                        // @formatter:on
+                        .section("note").optional() //
+                        .match("^(?<note>Auftrags-Nr\\. \\d+)-[\\d]{2}\\.[\\d]{2}\\.[\\d]{4}$") //
+                        .assign((t, v) -> t.setNote(trim(v.get("note"))))


trim() for what?

iAppDeveloper88 · 2026-03-11T12:48:12Z

Thank you for your comments @Nirus2000. I resolved most of them already; to some of them i added a question. I will rename the importer after i fixed all issues from your review.
The TODO is because i have some more dividend documents (for "Thesaurierende und Ausschüttende Fonds/ETFs"). It wont be there in my final pull request

…documents

…split and cancellation

gamue reviewed Mar 8, 2026

View reviewed changes

iAppDeveloper88 force-pushed the feat-pdf-oberbank branch from 2463df1 to f64f7cc Compare March 10, 2026 13:52

Nirus2000 reviewed Mar 11, 2026

View reviewed changes

iAppDeveloper88 force-pushed the feat-pdf-oberbank branch from 24b64a3 to 7f82160 Compare March 16, 2026 08:33

iAppDeveloper88 added 9 commits March 19, 2026 14:58

Added PDF Extractor for Oberbank, implemented import of Buy and Sell …

6ca08e0

…documents

Changes based on code review

72c1e49

Added import of delivery inbound and outbound documents for Oberbank

3eac137

Added import of dividend documents for Oberbank

b308d60

PDF importer for Oberbank now supports buy and sell documents for funds

3382265

Changes based on code review

49e1f49

Added more types of dividend and buying documents; Handling security …

6672d77

…split and cancellation

Handling ex-date for Oberbank dividend PDF imports

0fbf727

Renamed PDF Importer for Oberbank

96322b4

iAppDeveloper88 force-pushed the feat-pdf-oberbank branch from 3746e65 to 96322b4 Compare March 19, 2026 13:59

iAppDeveloper88 marked this pull request as ready for review March 19, 2026 13:59

Bugfix Oberbank dividend documents

db4c44c


		var pdfTransaction = new Transaction<BuySellEntry>();

		// var firstRelevantLine = new


		// @formatter:off
		// Kupon 4,55 % jährlich Stückzinsen f. 166 Tage EUR 165,55

Conversation

iAppDeveloper88 commented Mar 8, 2026

Uh oh!

gamue left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iAppDeveloper88 commented Mar 9, 2026

Uh oh!

iAppDeveloper88 commented Mar 9, 2026

Uh oh!

gamue commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nirus2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iAppDeveloper88 commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gamue left a comment •

edited

Loading

gamue commented Mar 9, 2026 •

edited

Loading