trade republic - adding new format for sepa direct debit#5543
Open
christen90 wants to merge 1 commit intoportfolio-performance:masterfrom
Open
trade republic - adding new format for sepa direct debit#5543christen90 wants to merge 1 commit intoportfolio-performance:masterfrom
christen90 wants to merge 1 commit intoportfolio-performance:masterfrom
Conversation
gamue
reviewed
Mar 7, 2026
| new AssertImportActions().check(results, "EUR"); | ||
|
|
||
| // assert transaction | ||
| assertThat(results, hasItem(removal(hasDate("2026-02-16"), hasAmount("EUR", 100.01), |
Contributor
There was a problem hiding this comment.
Thanks for contributing, generally looks fine. Only thing I see is that the formatting of the test-assertion isn't like the other ones. Please note that there are multiple forced line-breaks with // in the others
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing and the feedback. I just copied the one above. What you mean with others?
Contributor
There was a problem hiding this comment.
you're right, looks like the removal-assertions don't have that extra // like securtiy or buy/sell-events
Contributor
Author
|
Hi, BR Christian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.