Improvement: IBFlex allow re-marking "OK" entry for import#5534
Conversation
After right-clicking and setting a valid entry as "Do not import", make it possible to revert it to "Import".
| || (!entry.isImported() && (entry.getMaxCode() == Code.WARNING)); | ||
| || (!entry.isImported() && (entry.getMaxCode() == Code.WARNING | ||
| || (entry.getMaxCode() == Code.OK && entry.isExplicitlyNotImported()))); |
There was a problem hiding this comment.
Good catch. But couldn't we simplify even further:
If it the item
a) is currently not imported AND
b) it could be imported (e.g. the maxcode is WARNING or OK)
then the user can change the decision.
If it is FAILURE, of course, the user cannot make that decision. Same is true for SKIP (= transactions not supported by PP)
atLeastOneNotImported = atLeastOneNotImported || (!entry.isImported()
&& (entry.getMaxCode() == Code.WARNING || entry.getMaxCode() == Code.OK));There was a problem hiding this comment.
I don't think so, because user choice is not the only reason that entry.isImported() can be false – it includes a dependency check.
So if you decide based on maxCode, the app might allow the user to explicitly mark an entry to be imported, but then it won't be. I think that's a less good UI.
There was a problem hiding this comment.
Incidentally, I would say this area is slightly muddled. There are two questions: whether the entry CAN be imported and whether the user WANTS it imported.
The concept seems to be that "can" is represented by maxCode and the icon.
However, a piece of "can" has ended up mixed up with "want" in the code (isImported()), which is presumably what misled you into thinking the code could be simpler. And it's leaked into the UI, too, using strikethrough for both user choice AND for entries blocked by failed dependencies.
There was a problem hiding this comment.
@buchen did I address your comment? Anything further to do to get this merged?
2 participants
I noticed in the IBFlex process you can right-click to mark an "OK" transaction as "Do not import" but you cannot then revert that flag! That seems like a gap to me.