Skip to content

fix: ellipsize headerbar title instead of wrapping#1140

Merged
jackpot51 merged 1 commit intopop-os:masterfrom
hojjatabdollahi:hojjat/fix-headerbar-title
Mar 2, 2026
Merged

fix: ellipsize headerbar title instead of wrapping#1140
jackpot51 merged 1 commit intopop-os:masterfrom
hojjatabdollahi:hojjat/fix-headerbar-title

Conversation

@hojjatabdollahi
Copy link
Contributor

@hojjatabdollahi hojjatabdollahi commented Feb 23, 2026

Before:
image

After:
image


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@git-f0x
Copy link
Contributor

git-f0x commented Feb 23, 2026

Just a note that on e.g. KDE, the titles are ellipsized in the middle, so maybe it makes sense to do the same in libcosmic.

@hojjatabdollahi
Copy link
Contributor Author

Interesting. I assume I should do the same for tab_text too. Right?

@git-f0x
Copy link
Contributor

git-f0x commented Feb 23, 2026

Tab text might be different (at least for comp), since it often just ends with the name of the app, which isn't too useful.
I added ellipsizing at the end for the App Tray, since the info at the start is more important than seeing e.g. xyz...(Fi)les.

@hojjatabdollahi
Copy link
Contributor Author

Maybe the ui/ux team can chime in.

I don't think ellipsize::middle makes a lot of sense, it's not that readable.

image

@hojjatabdollahi hojjatabdollahi force-pushed the hojjat/fix-headerbar-title branch from 1f14b3a to e89ad44 Compare February 23, 2026 20:56
@hojjatabdollahi
Copy link
Contributor Author

We can probably move forward with this PR, now that Maria has Okayed it.

@jackpot51 jackpot51 merged commit bd1d3d5 into pop-os:master Mar 2, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants