Refactoring of dbus/async code, using new calloop version#2160
Draft
Refactoring of dbus/async code, using new calloop version#2160
Conversation
Member
ids1024
commented
Mar 6, 2026
ids1024
commented
- I have disclosed use of any AI generated code in my commit messages.
- If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
- In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
- I understand these changes in full and will be able to respond to review comments.
- My change is accurately described in the commit message.
- My contribution is tested and working as described.
- I have read the Developer Certificate of Origin and certify my contribution under its conditions.
New version of callop has a fix for this, so we're no longer blocked from using it.
If we don't use this anyway, this can make things simpler.
We should avoid creating more than one session connection or more than one system connection. We should also ideally avoid blocking the main thread. This moves the `NameOwners` creation out of `A11yKeyboardMonitorState`, so it can be shared with other things. We will likely want that for #465 to define a secured protocol to pass an fd to the portal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.