fix(#2138): dismiss window switcher on modifier release for custom shortcuts#2144
Open
thmsnhl wants to merge 1 commit intopop-os:masterfrom
Open
Conversation
The window switcher previously only auto-dismissed (activating the selected window) when the Super key was released, which was hardcoded specifically for the default Super+Tab binding. Custom shortcuts using other modifier keys (e.g. Ctrl+Tab) would leave the switcher open after key release, requiring the user to manually click a window or press a number key to confirm the selection. This fix extends the auto-dismiss-on-release behavior to any custom window-switcher shortcut: when the trigger modifier(s) are released, the switcher now activates the highlighted window and closes, matching the behavior of the built-in Super+Tab binding. Fixes pop-os#2138 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
thmsnhl
force-pushed
the
fix/issue-2138-fix-custom-shortcuts-for-switching-windows
branch
from
97e1661 to
8721c51
Compare
Member
|
I don't think this is a particularly good solution to the problem, as we are duplicating logic across cosmic-launcher and cosmic-comp. cosmic-launcher should rather track the modifier state on it's invocation to handle different shortcuts or read the shortcuts file from cosmic-comp to figure out the state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window switcher previously only auto-dismissed (activating the selected window) when the Super key was released, which was hardcoded specifically for the default Super+Tab binding. Custom shortcuts using other modifier keys (e.g. Ctrl+Tab) would leave the switcher open after key release, requiring the user to manually click a window or press a number key to confirm the selection.
This fix extends the auto-dismiss-on-release behavior to any custom window-switcher shortcut: when the trigger modifier(s) are released, the switcher now activates the highlighted window and closes, matching the behavior of the built-in Super+Tab binding.
Fixes #2138
The code has been written in collaboration with Claude Code Opus 4.6, in order to for me to understand the repository and code structure of Pop!_OS. I Tested it on my own machine running the latest stable build of Pop!_OS.