fix: use text widget instead of custom tab_text#2131
Closed
hojjatabdollahi wants to merge 2 commits intopop-os:masterfrom
Closed
fix: use text widget instead of custom tab_text#2131hojjatabdollahi wants to merge 2 commits intopop-os:masterfrom
hojjatabdollahi wants to merge 2 commits intopop-os:masterfrom
Conversation
hojjatabdollahi
force-pushed
the
hojjat/fix-headerbar
branch
from
b7acb5a to
b2f263c
Compare
git-f0x
reviewed
Mar 2, 2026
hojjatabdollahi
force-pushed
the
hojjat/fix-headerbar
branch
from
b2f263c to
4d8fce2
Compare
hojjatabdollahi
force-pushed
the
hojjat/fix-headerbar
branch
from
4d8fce2 to
8cdaed7
Compare
git-f0x
reviewed
Mar 2, 2026
hojjatabdollahi
force-pushed
the
hojjat/fix-headerbar
branch
from
8cdaed7 to
51e2880
Compare
Contributor
|
Actually, specifying the font with |
hojjatabdollahi
force-pushed
the
hojjat/fix-headerbar
branch
from
51e2880 to
b1ccca0
Compare
git-f0x
approved these changes
Mar 2, 2026
Contributor
git-f0x
left a comment
git-f0x
left a comment
There was a problem hiding this comment.
Seems to match previous behavior (other than having ellipsize), with the text of the active tab becoming semibold and accent-colored, and the close button disappearing for non-active tabs when the tab is narrow enough.
A potential future improvement could be to not show any text (only icon) for non-active tabs if it would end up being only "..." (at really narrow widths, only ".." is visible), using that extra width for the active tab. But that's out of scope of this PR.
Contributor
Author
|
superseded by #2180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft while waiting for pop-os/libcosmic#1140Ellipsizes the window title in SSD and tab text for stacked windows.