Allow to disable workspace switch animation in AppearanceConfig#2030
Open
andude10 wants to merge 1 commit intopop-os:masterfrom
Open
Allow to disable workspace switch animation in AppearanceConfig#2030andude10 wants to merge 1 commit intopop-os:masterfrom
andude10 wants to merge 1 commit intopop-os:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new setting to disable the animation that happens when switching between workspaces. Putting it inside AppearanceConfig allowed minimal changes, but I'm not sure if it is a good place for it in general.
I've been using this for a few days, but there's one issue with cosmic-workspace-applet (Numbered Workspaces), which happens in overview mode as well. The workspace number becomes highlighted only after some delay, you can see it in a video. It happens because the applet is not immediately notified, I think. I couldn't debug it, unfortunately, but I figured that adding 'state.common.refresh();' right after 'shell.move_window' fixes the issue.
Showcase: https://github.com/user-attachments/assets/32cf4201-02d5-4426-8ec6-25d50a5af001
Happy to hear any feedback. Feel free to reject if you have a different implementation in mind.