Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least on one system, I'm seeing monitors turn back on about 10 seconds after cosmic-idle has faded out and set DPMS to off.
It seems it's getting an
OutputChangeswithremoveddue to the CRTC changing?I'm am able to get it working with a change to
allow_frame_flags(), a couple changes to the behavior ofclear()in smithay (ids1024/smithay@3042f62), and a change to cosmic-idle to apply when awl_outputis added (pop-os/cosmic-idle#23). Though this isn't quite the right way to fix it...Checking for changes to the CRTC number seems problematic when
.clear()is settingCRTC_IDto0....