Rename bare-session files not to overwrite cosmic-session#1997
Open
hojjatabdollahi wants to merge 1 commit intopop-os:masterfrom
Open
Rename bare-session files not to overwrite cosmic-session#1997hojjatabdollahi wants to merge 1 commit intopop-os:masterfrom
hojjatabdollahi wants to merge 1 commit intopop-os:masterfrom
Conversation
Member
|
They aren't meant to be in sync, this is (intentionally) a standalone session of just cosmic-comp. But I agree the breakage isn't very nice nor intended, so we probably should rename the files. |
Running `make install-bare-session` installs a compositor-only session. It should not rewrite files installed by `cosmic-session`.
hojjatabdollahi
force-pushed
the
hojjat/remove-outdated-files
branch
from
5a6779f to
465e251
Compare
Contributor
Author
|
@Drakulix I see. I renamed the files instead of deleting them. Suggesting to call it "Cosmic compositor-only session". |
hojjatabdollahi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
make install-bare-sessionbreaks your system (login loop and other issues) because it overwritescosmic-session's files with outdated files.Instead of keeping these files updated and in sync with cosmic-session, we should probably just remove them.Renaming them.