Conversation
* simplify provider interface - tests passing * chore: fix chain id parse in polywrap signer new method --------- Co-authored-by: Cesar <[email protected]>
feat(provider): handle local sign support in necessary methods
…rface feat: simplify provider interface
feat: add sign typed data
chore: update wrapper-ci workflow
…karound # Conflicts: # provider/implementations/js/src/index.ts # provider/implementations/js/src/schema.graphql
…estnet examples used in connections.spec.ts
solidityPack workaround
extend fix for string parsing to other param types
chore: use eth sign typed data v4
This was referenced Mar 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this release we've: simplified the
ethereum-providerinterface, improve the JS implementation, and added a helpful utility function to theethereumwrapper.Features
wraps.eth:[email protected]wraps.eth:[email protected]solidityPack(types: [String!]!, values: [String!]!): String!wraps.eth:[email protected]Env.connection, enabling another option for connection configuration.signerAddress(connection: Connection): String@polywrap/ethereum-provider-js@0.3.0wraps.eth:[email protected]interface.Breaking Changes
wraps.eth:ethereum-provideraddress(connection: Connection): String!chainId(connection: Connection): String!Bugs
@polywrap/ethereum-provider-js@0.3.0eth_sendTransactionandeth_signTypedData_v4when a custom signer is being used.