fix(sdk): auction-based bid collection & blockTime fix#749
Closed
seunlanlege wants to merge 2 commits intomainfrom
Closed
fix(sdk): auction-based bid collection & blockTime fix#749seunlanlege wants to merge 2 commits intomainfrom
seunlanlege wants to merge 2 commits intomainfrom
Conversation
Replace minBids with required auctionTimeMs to collect bids for a fixed duration before selecting the best one. Fix blockTime sleep calculation — viem's chain.blockTime is already in milliseconds, removing the redundant * 1_000 multiplier.
seunlanlege
force-pushed
the
fix/improve-order-executor
branch
from
c84f179 to
192fa84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minBidswith requiredauctionTimeMs— waits for the auction duration to collect bids before selecting the best one, rather than proceeding as soon as a minimum count is reachedblockTimesleep calculation indeadlineStream—chain.blockTimefrom viem is already in milliseconds, so the* 1_000multiplier was making the sleep 1000x too longTest plan
executeandresumerequireauctionTimeMs