Unstuck Snowbridge by claravanstaden · Pull Request #313 · polkadot-fellows/runtimes

claravanstaden · 2024-05-17T13:54:38Z

Upgrades Snowbridge with an Ethereum client fixes:

Snowbridge - Ethereum Client - Public storage items paritytech/polkadot-sdk#4504
Snowbridge - Ethereum Client - Reject finalized updates without a sync committee in next store period paritytech/polkadot-sdk#4482

Adds a migration to reset the Ethereum checkpoint. Will be reset again to the moment recent checkpoint before merged.

TODO:

Check migration works
Check converting Sync Committee to prepared keys is OK for a migration

…-snowbridge

acatangiu · 2024-05-17T14:05:09Z

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_unstuck.rs

+
+pub struct UnstuckSnowbridge;
+
+impl OnRuntimeUpgrade for UnstuckSnowbridge {


You also need to add it to the list of migrations (example)

Thanks for the reminder! b13f7a9

claravanstaden · 2024-05-17T14:10:01Z

@acatangiu the migration is roughly doing the same as the force_checkpoint extrinsic. It looks like an expensive operation compared to the P<>K bridge migration - the weight is Weight::from_parts(101_492_831_000, 0). Do you think this will be a problem? We'll test of course but just wanted to also ask your opinion.

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_unstuck.rs

acatangiu · 2024-05-17T14:11:26Z

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_unstuck.rs

+}
+
+fn is_bridge_stuck() -> bool {
+    LatestFinalizedBlockRoot::<Runtime>::get() == LAST_IMPORTED_BEACON_HEADER.into()


We expect that this LAST_IMPORTED_BEACON_HEADER will not be reimported, yes?

(I guess the checkpoint is from a block newer than that)

acatangiu · 2024-05-17T14:15:35Z

@acatangiu the migration is roughly doing the same as the force_checkpoint extrinsic. It looks like an expensive operation compared to the P<>K bridge migration - the weight is Weight::from_parts(101_492_831_000, 0). Do you think this will be a problem? We'll test of course but just wanted to also ask your opinion.

Should be ok as long as it fits a block.

…o_ethereum_unstuck.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>

…-snowbridge

vgeddes · 2024-05-17T15:03:56Z

@acatangiu the migration is roughly doing the same as the force_checkpoint extrinsic. It looks like an expensive operation compared to the P<>K bridge migration - the weight is Weight::from_parts(101_492_831_000, 0). Do you think this will be a problem? We'll test of course but just wanted to also ask your opinion.

Should be ok as long as it fits a block.

Yeah this is fine, is well below the block limit. And we know it works because our initial governance proposal already executed a force_checkpoint successfully on BridgeHub.

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_unstuck.rs

vgeddes

+1

acatangiu

Migration code looks good, also validated that the new checkpoint leads to https://beaconscan.com/slot/9094528.

Check is_bridge_upgraded at post_upgrade phase

This reverts commit 7bb13b7, reversing changes made to c8eb5ee.

joepetrowski · 2024-05-19T12:53:01Z

/merge

fellowship-merge-bot · 2024-05-19T12:54:23Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

claravanstaden added 2 commits May 17, 2024 15:50

unstuck snowbridge

c6e82e1

Merge branch 'main' into unstuck-snowbridge

c1e726b

claravanstaden mentioned this pull request May 17, 2024

Proposing: v1.2.4 Release #288

Closed

10 tasks

claravanstaden added 2 commits May 17, 2024 16:04

more tests

1b0b738

Merge remote-tracking branch 'origin/unstuck-snowbridge' into unstuck…

06d0ae0

…-snowbridge

acatangiu reviewed May 17, 2024

View reviewed changes

adds migration

b13f7a9

acatangiu reviewed May 17, 2024

View reviewed changes

claravanstaden and others added 6 commits May 17, 2024 16:23

Update system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_t…

68877e5

…o_ethereum_unstuck.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>

Update system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_t…

1b555da

…o_ethereum_unstuck.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>

Update system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_t…

dcee64e

…o_ethereum_unstuck.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>

compiler fixes

bdde1f9

Merge remote-tracking branch 'origin/unstuck-snowbridge' into unstuck…

5dcb03c

…-snowbridge

compiler warnings

ec0c1a3

vgeddes and others added 4 commits May 17, 2024 17:30

Previous checkpoint was invalid

ba71a05

misc cleanups

33d0bf4

rustfmt

934eddd

Merge branch 'main' into unstuck-snowbridge

9f9471c

claravanstaden marked this pull request as ready for review May 17, 2024 17:23

claravanstaden and others added 3 commits May 17, 2024 19:38

fix header root

b90e2f4

updates changelog

b14ec76

Simplify migration script (#10)

15f2aee

claravanstaden commented May 17, 2024

View reviewed changes

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_unstuck.rs Outdated Show resolved Hide resolved

claravanstaden added 3 commits May 17, 2024 20:18

set weight to force checkpint

fd724f3

fmt

f5472d2

fix if

c8eb5ee

vgeddes approved these changes May 17, 2024

View reviewed changes

yrong added 2 commits May 18, 2024 08:32

Check is_bridge_upgraded at post_upgrade phase

5b08b34

Fix for clippy

19dd360

acatangiu approved these changes May 18, 2024

View reviewed changes

yrong and others added 5 commits May 18, 2024 18:41

Merge pull request #11 from Snowfork/ron/unstuck-snowbridge

7bb13b7

Check is_bridge_upgraded at post_upgrade phase

Merge branch 'main' into unstuck-snowbridge

35ce909

Revert "Merge pull request #11 from Snowfork/ron/unstuck-snowbridge"

44b985f

This reverts commit 7bb13b7, reversing changes made to c8eb5ee.

Box CheckpointUpdate

8c6e256

Import Box

bf1b5c0

alistair-singh approved these changes May 19, 2024

View reviewed changes

joepetrowski approved these changes May 19, 2024

View reviewed changes

fellowship-merge-bot bot merged commit 2f8a10e into polkadot-fellows:main May 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unstuck Snowbridge#313

Unstuck Snowbridge#313
fellowship-merge-bot[bot] merged 28 commits intopolkadot-fellows:mainfrom
Snowfork:unstuck-snowbridge

claravanstaden commented May 17, 2024 •

edited

Loading

Uh oh!

acatangiu May 17, 2024

Uh oh!

claravanstaden May 17, 2024

Uh oh!

claravanstaden commented May 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acatangiu May 17, 2024

Uh oh!

acatangiu commented May 17, 2024

Uh oh!

vgeddes commented May 17, 2024

Uh oh!

Uh oh!

vgeddes left a comment

Uh oh!

acatangiu left a comment

Uh oh!

joepetrowski commented May 19, 2024

Uh oh!

fellowship-merge-bot bot commented May 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		pub struct UnstuckSnowbridge;

		impl OnRuntimeUpgrade for UnstuckSnowbridge {

Conversation

claravanstaden commented May 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acatangiu May 17, 2024

Choose a reason for hiding this comment

Uh oh!

claravanstaden May 17, 2024

Choose a reason for hiding this comment

Uh oh!

claravanstaden commented May 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acatangiu May 17, 2024

Choose a reason for hiding this comment

Uh oh!

acatangiu commented May 17, 2024

Uh oh!

vgeddes commented May 17, 2024

Uh oh!

Uh oh!

vgeddes left a comment

Choose a reason for hiding this comment

Uh oh!

acatangiu left a comment

Choose a reason for hiding this comment

Uh oh!

joepetrowski commented May 19, 2024

Uh oh!

fellowship-merge-bot bot commented May 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

claravanstaden commented May 17, 2024 •

edited

Loading