Skip to content

[encointer] introduce collator selection and send fees to authors instead of treasury#270

Merged
fellowship-merge-bot[bot] merged 38 commits into
polkadot-fellows:mainfrom
encointer:ab/introduce_collator-selection
May 21, 2024
Merged

[encointer] introduce collator selection and send fees to authors instead of treasury#270
fellowship-merge-bot[bot] merged 38 commits into
polkadot-fellows:mainfrom
encointer:ab/introduce_collator-selection

Conversation

@brenzi
Copy link
Copy Markdown
Contributor

@brenzi brenzi commented Apr 10, 2024 •
edited
Loading

closes #183
closes #176
closes #146 (should be closed already, but this PR adds more)

This PR aligns collator selection and fee distribution logic of Encointer with other system chains and thereby is a small step towards self-sustainability of infrastructure

  • remove treasury (and leave negligible funds on trsry account)
  • add collator-selection, session and authorship pallets
  • instead of burning fees in community currency , send them to block authors like native KSM
  • remove DMP queue pallet (pure cleanup, no change in functionality)
  • add migration to inject existing collators as invulnerables
  • remove applied migrations from release 1.2.0

steps to reproduce the new fee logic: https://gist.github.com/brenzi/ca9e0c326198c73ff2dd0a2e74468053

brenzi
brenzi commented Apr 10, 2024
View reviewed changes
Comment thread system-parachains/encointer/src/migrations_fix.rs
@brenzi brenzi mentioned this pull request Apr 10, 2024
Merged
@brenzi brenzi marked this pull request as ready for review April 10, 2024 18:04
@brenzi brenzi mentioned this pull request Apr 10, 2024
Closed
3 tasks
clangenb
clangenb reviewed Apr 15, 2024
View reviewed changes
Comment thread system-parachains/encointer/src/lib.rs Outdated
joepetrowski
joepetrowski reviewed Apr 17, 2024
View reviewed changes
Comment thread system-parachains/encointer/src/lib.rs Outdated
Comment thread system-parachains/encointer/src/lib.rs
Comment thread system-parachains/encointer/src/migrations_fix.rs
Comment thread system-parachains/encointer/src/migrations_fix.rs Outdated
Comment thread system-parachains/encointer/src/migrations_fix.rs
Comment thread system-parachains/encointer/src/migrations_fix.rs
@brenzi brenzi closed this Apr 18, 2024
@brenzi brenzi force-pushed the ab/introduce_collator-selection branch from db32586 to 31ba262 Compare April 18, 2024 13:38
@brenzi
Copy link
Copy Markdown
Contributor Author

brenzi commented Apr 18, 2024

darn. that was a mistake...

@brenzi brenzi reopened this Apr 18, 2024
@brenzi
Copy link
Copy Markdown
Contributor Author

brenzi commented May 1, 2024

I would claim your feedback up to this point has been addressed @joepetrowski. thanks a lot for your hints

@brenzi brenzi mentioned this pull request May 2, 2024
Closed
13 tasks
@liamaharon liamaharon mentioned this pull request May 7, 2024
Open
joepetrowski
joepetrowski approved these changes May 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KSM does go to the Staking Pot as expected:
https://gist.github.com/brenzi/ca9e0c326198c73ff2dd0a2e74468053#file-gistfile1-txt-L50-L64

@brenzi
Copy link
Copy Markdown
Contributor Author

brenzi commented May 7, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot Bot enabled auto-merge (squash) May 7, 2024 11:41
@fellowship-merge-bot
Copy link
Copy Markdown
Contributor

fellowship-merge-bot Bot commented May 7, 2024

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot
Copy link
Copy Markdown
Contributor

fellowship-merge-bot Bot commented May 7, 2024

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot
Copy link
Copy Markdown
Contributor

fellowship-merge-bot Bot commented May 7, 2024

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

auto-merge was automatically disabled May 8, 2024 11:56

Head branch was pushed to by a user without write access

acatangiu
acatangiu approved these changes May 21, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
@acatangiu
Copy link
Copy Markdown
Contributor

acatangiu commented May 21, 2024

/merge

@fellowship-merge-bot
Copy link
Copy Markdown
Contributor

fellowship-merge-bot Bot commented May 21, 2024

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot Bot enabled auto-merge (squash) May 21, 2024 12:48
@fellowship-merge-bot fellowship-merge-bot Bot merged commit 2fe6f56 into polkadot-fellows:main May 21, 2024
@brenzi
Copy link
Copy Markdown
Contributor Author

brenzi commented May 22, 2024 •
edited
Loading

happy to announce the migration worked smoothly on rococo and the session pallet works as expected:
image

notice the author's appearing after the upgrade

migration log

May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.173  INFO tokio-runtime-worker runtime::frame-support: [Parachain] 🐥 New pallet "Authorship" detected in the runtime. The pallet has no defined storage version, so the on-chain version is being initialized to StorageVersio>
May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.174  INFO tokio-runtime-worker runtime::frame-support: [Parachain] 🐥 New pallet "CollatorSelection" detected in the runtime. Initializing the on-chain storage version to match the storage version defined in the pallet: Sto>
May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.174  INFO tokio-runtime-worker runtime::frame-support: [Parachain] 🐥 New pallet "Session" detected in the runtime. Initializing the on-chain storage version to match the storage version defined in the pallet: StorageVersio>
May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.180  INFO tokio-runtime-worker frame_support::migrations: [Parachain] Removed 1 DmpQueue keys 🧹
May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.180  INFO tokio-runtime-worker runtime::fix::collator_selection_init: [Parachain] initializing the set of invulnerables

@brenzi brenzi mentioned this pull request Jun 4, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clangenb clangenb clangenb left review comments

@georgepisaltu georgepisaltu georgepisaltu left review comments

@joepetrowski joepetrowski joepetrowski approved these changes

@acatangiu acatangiu acatangiu approved these changes

+1 more reviewer

@liamaharon liamaharon liamaharon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

implement collator-selection for Encointer remove treasury from Encointer runtime encointer chain-spec-generator genesis state config

6 participants

@brenzi @acatangiu @liamaharon @joepetrowski @clangenb @georgepisaltu