Skip to content

[XCM]: Improved fee mechanism#105

Merged
paritytech-rfc-bot[bot] merged 6 commits intopolkadot-fellows:mainfrom
franciscoaguirre:xcm-fee-mechanism
Sep 3, 2024
Merged

[XCM]: Improved fee mechanism#105
paritytech-rfc-bot[bot] merged 6 commits intopolkadot-fellows:mainfrom
franciscoaguirre:xcm-fee-mechanism

Conversation

@franciscoaguirre
Copy link
Copy Markdown
Contributor

Moved from polkadot-fellows/xcm-format#53.

The idea is to extend the current XCM fee mechanism to support in principle delivery fees, but potentially other types of fees as well.
This is accomplished by having two additions:

  • PayFees instruction
  • A fees register, where fees go and stay there until the end of execution. Crucially, separate from the holding register

@franciscoaguirre
Copy link
Copy Markdown
Contributor Author

/rfc propose

@paritytech-rfc-bot
Copy link
Copy Markdown
Contributor

Hey @franciscoaguirre, here is a link you can use to create the referendum aiming to approve this RFC number 0105.

Instructions
  1. Open the link.

  2. Switch to the Submission tab.

  1. Adjust the transaction if needed (for example, the proposal Origin).

  2. Submit the Transaction


It is based on commit hash dbda71ff556635b523656c8e8af42686d5515372.

The proposed remark text is: RFC_APPROVE(0105,3a2279090ec273a091e02cea25323279745f22391f35b24462279188dfc07734).

@github-actions
Copy link
Copy Markdown

Voting for this referenda is ongoing.

Vote for it here

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2024

PR can be merged.

Write the following command to trigger the bot

/rfc process 0x39efd93063aeaef13afdb2135a775fec4d87fe3ed51e9bf122bc73a336acd509

@acatangiu
Copy link
Copy Markdown
Contributor

/rfc process 0x39efd93063aeaef13afdb2135a775fec4d87fe3ed51e9bf122bc73a336acd509

@paritytech-rfc-bot paritytech-rfc-bot bot merged commit db260ea into polkadot-fellows:main Sep 3, 2024
@paritytech-rfc-bot
Copy link
Copy Markdown
Contributor

The on-chain referendum has approved the RFC.

@anaelleltd anaelleltd added the Approved Has passed on-chain voting. label Sep 10, 2024
acatangiu added a commit to paritytech/polkadot-sdk that referenced this pull request Oct 17, 2024
Implements [RFC#105](polkadot-fellows/RFCs#105)
which, at the time of this PR, has not been approved yet. Some aspects
might be changed as a result of discussion.

## TODO
- [x] Add new instruction and use it in conversion functions
- [x] Implement in xcm-executor
- [x] Setup for xcm-executor unit tests
- [x] Actual xcm-executor unit tests
  - [x] Happy path
  - [x] Unhappy path
- [x] Emulated tests
  - [x] Asset hub westend
  - [x] Asset hub rococo
- [x] Benchmarks
  - [x] Dummy values
  - [x] Actual benchmarks
- [x] PRDoc

---------

Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
@anaelleltd anaelleltd added Implemented Is merged or live as a feature/service. and removed Approved Has passed on-chain voting. labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Implemented Is merged or live as a feature/service.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants