Allow to initialize "pending" blocks in a specific way (add runtime api pending_initialize_block)#1253
Merged
boundless-forest merged 2 commits intopolkadot-evm:masterfrom Aug 1, 2024
Conversation
sorpaas
approved these changes
Jan 3, 2024
Member
Author
|
@sorpaas @boundless-forest can someone merge this PR? |
boundless-forest
approved these changes
Aug 1, 2024
ipapandinas
pushed a commit
to AstarNetwork/frontier
that referenced
this pull request
Sep 4, 2024
magecnion
added a commit
to freeverseio/laos
that referenced
this pull request
Sep 12, 2024
asiniscalchi
added a commit
to freeverseio/laos
that referenced
this pull request
Nov 29, 2024
* uplift to stable2407 * paritytech/polkadot-sdk#4831 * paritytech/polkadot-sdk#3820 * polkadot-evm/frontier#1253 * paritytech/polkadot-sdk#3952 * paritytech/polkadot-sdk#3872 * fix rpc_builder type * paritytech/polkadot-sdk#4410 * paritytech/polkadot-sdk#4097 * use stable rust toolchain * paritytech/polkadot-sdk#3964 * cargo fmt * clippy and lint issues * e2e-test estimate gas when delegating * only run staking e2e-test so it's easier for reviewing by external * only run staking e2e-test so it's easier for reviewing by external * restore run all e2e tests * Update Rust Toolchain to 1.77, Suppress Warnings, and Enhance Runtime (#778) * using runt 1.77 * fix clippy errors * fixing clippy * update to runtime 2200 * update proyect version to 0.22.0 * add missing migration * removed the upgrade of versioning * update cargo.lock * using runtime * fix command * fix compilation * fix metadata test * missing Config associated type * modify MaxPageSize to the original till we need to increase it * use latest release for zombienet tests * go back to stable2407-3 release for zombienet tests * go back to previous MaxPageSize --------- Co-authored-by: Alessandro Siniscalchi <asiniscalchi@gmail.com> Co-authored-by: luispdm <17044119+luispdm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At moonbeam, we necessarily need to initialize "pending" bloks in a different way to classic blocks, because our pallet randomness panics at
on_initializehook if the node doesn't have a VRF key in its keystore.We need to tell our pallet that we're in the context of a "pending" block built by an RPC provider, and not a normal block. Somehow, we need to modify the client/runtime interface to tell the runtime that we're in the context of a "pending" block, the simplest solution we've found is to add a new method to the runtime API
EthereumRuntimeRPCApi.