Skip to content

Upgrade Substrate to polkadot-sdk#1193

Closed
nazar-pc wants to merge 5 commits intopolkadot-evm:masterfrom
nazar-pc:upgade-substrate-old-repo
Closed

Upgrade Substrate to polkadot-sdk#1193
nazar-pc wants to merge 5 commits intopolkadot-evm:masterfrom
nazar-pc:upgade-substrate-old-repo

Conversation

@nazar-pc
Copy link
Copy Markdown

This is a straightforward mechanical upgrade, nothing fancy here, mostly things were simplified a bit upstream.

The first step is to catch up with old repo, after this upgrade to polkadot-sdk should be much easier.

@nazar-pc nazar-pc requested a review from sorpaas as a code owner September 12, 2023 18:19
@nazar-pc
Copy link
Copy Markdown
Author

Not sure about integration tests, but regular tests all succeeded for me locally, while CI seems to be broken here

@koushiro
Copy link
Copy Markdown
Collaborator

There is already a PR #1165 for upgrading substrate.
There is also a PR #1191 to fix CI.

@nazar-pc
Copy link
Copy Markdown
Author

Hm, I somehow didn't notice #1165. Why not upgrading to latest version there though?

@nazar-pc nazar-pc changed the title Upgade Substrate old repo Upgrade Substrate old repo Sep 13, 2023
@koushiro
Copy link
Copy Markdown
Collaborator

Why not upgrading to latest version there though?

I usually only update the substrate deps of frontier's master branch when the team releases a new version of polkadot. This can reduce maintenance work, and the master branch of substrate usually does not have good stability.

@koushiro
Copy link
Copy Markdown
Collaborator

It seems that polkadot is about to release v1.1.0, and then we can directly migrate to polkadot-sdk repo

@nazar-pc nazar-pc force-pushed the upgade-substrate-old-repo branch 3 times, most recently from 597ceb2 to 7d90c6d Compare September 13, 2023 08:07
@nazar-pc
Copy link
Copy Markdown
Author

Rebased against newly merged PRs in master

@nazar-pc nazar-pc force-pushed the upgade-substrate-old-repo branch from 7d90c6d to 8a0da7d Compare September 13, 2023 08:13
@nazar-pc nazar-pc force-pushed the upgade-substrate-old-repo branch from 8a0da7d to 068cb2e Compare September 13, 2023 08:50
@nazar-pc
Copy link
Copy Markdown
Author

Fixed lints as well

@nazar-pc nazar-pc changed the title Upgrade Substrate old repo Upgrade Substrate to polkadot-sdk Sep 14, 2023
@nazar-pc
Copy link
Copy Markdown
Author

Pulled current master of polkadot-sdk, only new changes were a few imports that changed during refactoring.

@sorpaas
Copy link
Copy Markdown
Member

sorpaas commented Sep 25, 2023

superseded by #1201

@sorpaas sorpaas closed this Sep 25, 2023
@nazar-pc nazar-pc deleted the upgade-substrate-old-repo branch September 25, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants