Update the approach to obtain (weight_limit, proof_size_base_cost)#1121
Merged
sorpaas merged 5 commits intopolkadot-evm:masterfrom Jul 30, 2023
Merged
Update the approach to obtain (weight_limit, proof_size_base_cost)#1121sorpaas merged 5 commits intopolkadot-evm:masterfrom
(weight_limit, proof_size_base_cost)#1121sorpaas merged 5 commits intopolkadot-evm:masterfrom
Conversation
Closed
37 tasks
frank0528
pushed a commit
to DeepBrainChain/DBC-EVM
that referenced
this pull request
Sep 10, 2024
…olkadot-evm#1121) * Move `proof_size_base_cost` out to reuse it * Add field * Reuse `transaction_weight` * Code clean * Fix clippy
frank0528
pushed a commit
to DeepBrainChain/DBC-EVM
that referenced
this pull request
Sep 24, 2024
…olkadot-evm#1121) * Move `proof_size_base_cost` out to reuse it * Add field * Reuse `transaction_weight` * Code clean * Fix clippy
frank0528
pushed a commit
to DeepBrainChain/DBC-EVM
that referenced
this pull request
Jan 2, 2025
…olkadot-evm#1121) * Move `proof_size_base_cost` out to reuse it * Add field * Reuse `transaction_weight` * Code clean * Fix clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reorganized the usage of
proof_size_base_costfunction and modified the approach to obtain (weight_limit, proof_size_base_cost).proof_size_base_costfield to theTransactionDatatype and calculate the proof size base cost while converting the transaction into the transaction data in the Ethereum pallet. So we don't need a seperateproof_size_base_cost(transaction: &Transaction)function. It can also be more easily reused by other projects.(weight_limit, proof_size_base_cost)into a functiontransaction_weight. It's used in many places.