Handling data and input fields in TransactionRequest and CallRequest#1096
Merged
sorpaas merged 11 commits intopolkadot-evm:masterfrom Jul 18, 2023
Merged
Conversation
|
User @ahmadkaouk, please sign the CLA here. |
tgmichel
approved these changes
Jul 4, 2023
koushiro
reviewed
Jul 4, 2023
koushiro
reviewed
Jul 4, 2023
koushiro
reviewed
Jul 4, 2023
koushiro
reviewed
Jul 4, 2023
koushiro
reviewed
Jul 18, 2023
Comment on lines
+21
to
25
| use crate::types::{deserialize_data_or_input, Bytes}; | ||
| use ethereum::AccessListItem; | ||
| use ethereum_types::{H160, H256, U256}; | ||
| use serde::Deserialize; | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| use crate::types::{deserialize_data_or_input, Bytes}; | |
| use ethereum::AccessListItem; | |
| use ethereum_types::{H160, H256, U256}; | |
| use serde::Deserialize; | |
| use ethereum::AccessListItem; | |
| use ethereum_types::{H160, H256, U256}; | |
| use serde::Deserialize; | |
| use crate::types::{deserialize_data_or_input, Bytes}; | |
koushiro
approved these changes
Jul 18, 2023
sorpaas
approved these changes
Jul 18, 2023
Member
sorpaas
left a comment
sorpaas
left a comment
There was a problem hiding this comment.
Our project starts to smell Microsoft Windows..
noandrea
pushed a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Aug 28, 2023
…equest` (polkadot-evm#1096) * Update deserializing data and input fields in TransactionRequest * Custom deserializing for data and input in CallRequest * Manually implement Deserialize for TransactionRequest and CallRequest * Add some unit test for the custom deserialization * add functional tests * fix formatting * deserializer for aliased fields * custom deserializer for data and input fields in TransactionRequest * fix formatting * update functional test * refactor code and fix formatting --------- Co-authored-by: tgmichel <[email protected]>
Closed
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the handling of
dataandinputfields in TransactionRequest and CallRequest. Previously, provision of both fields resulted in errors.Key updates in this PR:
dataandinputfields no longer throw errors.dataandinputfields differ, an error is returned to prevent ambiguity.inputis provided, its value is used fordata.