Skip to content

Handle u64 conversion#1091

Merged
sorpaas merged 3 commits intopolkadot-evm:masterfrom
moonbeam-foundation:tgm-handle-u64-conversion
Jul 29, 2023
Merged

Handle u64 conversion#1091
sorpaas merged 3 commits intopolkadot-evm:masterfrom
moonbeam-foundation:tgm-handle-u64-conversion

Conversation

@tgmichel
Copy link
Copy Markdown
Contributor

@tgmichel tgmichel commented Jun 27, 2023

Safe U256 to u64 client side conversion

@tgmichel tgmichel requested a review from sorpaas as a code owner June 27, 2023 09:18
@sorpaas
Copy link
Copy Markdown
Member

sorpaas commented Jun 27, 2023

Would you mind to use https://paritytech.github.io/substrate/master/sp_arithmetic/traits/trait.UniqueSaturatedFrom.html?

@sorpaas
Copy link
Copy Markdown
Member

sorpaas commented Jun 28, 2023

Needs to resolve conflicts.

This was referenced Jul 29, 2023
Closed
Merged
@sorpaas sorpaas merged commit 071d030 into polkadot-evm:master Jul 29, 2023
sorpaas pushed a commit that referenced this pull request Jul 31, 2023
@koushiro @tgmichel
Handle u64 conversion (#1091) (#1124)
b520b74 
* Handle `u64` conversion

* suggestion switch to saturated conversion

Co-authored-by: tgmichel <telmo@purestake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorpaas sorpaas sorpaas approved these changes

Assignees

No one assigned

Labels

A4-needsresolving

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tgmichel @sorpaas