feat: add fc-api to improve fc-db#1076
feat: add fc-api to improve fc-db#1076sorpaas merged 5 commits intopolkadot-evm:masterfrom koushiro:add-fc-api
Conversation
|
cc @tgmichel |
| @@ -0,0 +1,20 @@ | |||
| [package] | |||
| name = "fc-api" | |||
There was a problem hiding this comment.
What do you think we name it fc-db-api instead?
There was a problem hiding this comment.
Because this crate may not only contain db-related APIs
There was a problem hiding this comment.
Can you explain more what you plan to add in the future? It's currently rather confusing for me though as another important "API" we have are the runtime APIs.
There was a problem hiding this comment.
It's named fc-api, so it should be a crate that includes client side API.
Currently we only have db-related API, if I want to split the implementation of db into different crates, then the mapping-sync crate is likely to be refactored, and maybe related apis will be put into this crate.
There was a problem hiding this comment.
Anyway let's go with this now. We can change the name later.
2 participants
after merging this PR, I'll split the kv backend and sql backend into different crates.