Improve block import notification strategy#1030
Merged
sorpaas merged 6 commits intopolkadot-evm:masterfrom May 8, 2023
Merged
Conversation
sorpaas
reviewed
Mar 27, 2023
Member
sorpaas
left a comment
sorpaas
left a comment
There was a problem hiding this comment.
LGTM, please fix cargo lints.
Contributor
Author
Done, please wait to merge I'm going to push some change |
Contributor
Author
|
@sorpaas added functionality to only notify when the node is synced, mostly to mimic what substrate block import notification does. What do you think of https://github.com/paritytech/frontier/pull/1030/files#diff-238ded0693b6a31db32cd68411cd48e079cd87097b3436fe7ef70b222b2eeb25R248-R249? do you think is reasonable to close the channel and remove it from memory when the node is in major syncing? |
# Conflicts: # template/node/src/rpc/mod.rs
ashutoshvarma
pushed a commit
to AstarNetwork/frontier
that referenced
this pull request
May 29, 2023
* Improve block import notification strategy * oops * taplo * clippy * Notify only when not major syncing
6 tasks
ashutoshvarma
pushed a commit
to AstarNetwork/frontier
that referenced
this pull request
Jun 8, 2023
* Improve block import notification strategy * oops * taplo * clippy * Notify only when not major syncing
Closed
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently use substrate block import notification stream in our pubsub module, that can lead to a race condition if a Dapp subscribes to
newHeadsand quickly after requests for data that requires the mapping in our offchain db to exist (i.e.eth_getBlockByHash). This data may or may not exist at that moment. As in any race condition cannot be reliably reproduced but this behaviour has been reported to exist in Moonbeam several times.This PR proposes to switch to use our own Ethereum block import notification stream, that is,
senda message through a channel when data is already mapped in our offchain db andreceivethrough the channel in the pubsub subscription.