Skip to content

Fixed; multiple-rpc-port-error-bug; #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wentelteefje merged 13 commits into from
Aug 18, 2023
Merged

Fixed; multiple-rpc-port-error-bug; #2041

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fa5d4e0
Updated; multiple-rpc-port bug; issue #2037
danisvice Aug 13, 2023
0049ee6
Update content/md/en/docs/tutorials/build-a-blockchain/simulate-netwo…
danisvice Aug 16, 2023
9ca8914
Updated; Removed unutilized ports & edited doc
danisvice Aug 16, 2023
5c16796
Updated; Edited Doc, added comma before 'and'
danisvice Aug 16, 2023
866a43a
Updated; Removed unutilized --rpc-ports
danisvice Aug 16, 2023
035928d
Updated;
danisvice Aug 16, 2023
d826097
Updated;
danisvice Aug 16, 2023
6e0c1b8
Complete; Simulate A Network Tutorial
danisvice Aug 16, 2023
34ebd42
Updated; Specifies --rpc-port listens to WS & RPC
danisvice Aug 16, 2023
64454ca
Updated; RPC Calls docs; 9933=>9944
danisvice Aug 16, 2023
3d331eb
Merge branch 'main' into fix-rpc-port-error
danisvice Aug 18, 2023
648166e
Update content/md/en/docs/tutorials/build-a-blockchain/simulate-netwo…
wentelteefje Aug 18, 2023
193de88
Update content/md/en/docs/tutorials/build-a-blockchain/simulate-netwo…
wentelteefje Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/md/en/docs/tutorials/build-a-blockchain/simulate-network.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ To start the blockchain:
--chain local \
--alice \
--port 30333 \
--rpc-port 9945 \
--rpc-port 9945 && \
--rpc-port 9933 \
--node-key 0000000000000000000000000000000000000000000000000000000000000001 \
--telemetry-url "wss://telemetry.polkadot.io/submit/ 0" \
Expand Down Expand Up @@ -169,7 +169,7 @@ To add a node to the running blockchain:
--chain local \
--bob \
--port 30334 \
--rpc-port 9946 \
--rpc-port 9946 && \
--rpc-port 9934 \
Copy link
Copy Markdown
Contributor

@liamaharon liamaharon Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--rpc-port 9946 && \
--rpc-port 9934 \
--rpc-port 9946 \

Copy link
Copy Markdown
Contributor Author

@danisvice danisvice Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the input @ghe0. I knew the nodes could start with only rpc port 9945, but I thought the problem was deeper than that, as far configuring the CLI itself and the runtime. Consensus is we move on without rpc ports 9933 && 9934.

Copy link
Copy Markdown
Contributor

@liamaharon liamaharon Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think this is fine.

However we need to ensure we update the rest of the docs on this page to match. Please check to make sure we don't mention these removed ports anywhere else, and also mention that both RPC and WS is exposed on --rpc-port.

--telemetry-url "wss://telemetry.polkadot.io/submit/ 0" \
--validator \
Expand Down