Conversation
hadoop835
commented
Dec 7, 2022
hadoop835
commented
|
|
Honestly I don't think this change is necessary, could you plz explain why these default setting should be written explicitly? |
|
@joeCarf Do you have a good solution to this problem？？？ |
Which approach are you using, are you debugging cn in your IDE or compile source code ? |
|
And what version is your Mysql? @hadoop835 |
https://github.com/ApsaraDB/galaxyengine 分支main，编译的 |
joeCarf
left a comment
joeCarf
left a comment
There was a problem hiding this comment.
After discussion, i think maybe this failure is caused by local environment, since cn can still start normally without metaDbProp.
However, metaDbProp is still necessary because others may wanna change link properties. That's why i approve this pr
|
|
||
| String metaDatabase = config.getMetaDbName(); | ||
| String innerUser = config.getMetaDbUser(); | ||
| String metaDbProp = config.getMetaDbProp(); |
There was a problem hiding this comment.
are you debuging cn?
I don't understand why these properties are useful here, casue they seems to be defalut settings..
lgjpolardbx
force-pushed
the
main
branch
7 times, most recently
from
89ea352 to
ba432af
Compare
5 participants
