fix: Fix lazy concat horizontal didn't raise on mismatching heights after projection pushdown#27506
Open
nameexhaustion wants to merge 9 commits intomainfrom
Open
fix: Fix lazy concat horizontal didn't raise on mismatching heights after projection pushdown#27506nameexhaustion wants to merge 9 commits intomainfrom
nameexhaustion wants to merge 9 commits intomainfrom
Conversation
github-actions
Bot
added
fix
Contributor
|
The uncompressed lib size after this PR is 61.3522 MB. |
nameexhaustion
changed the title
Contributor
|
The uncompressed lib size after this PR is 61.3522 MB. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27506 +/- ##
==========================================
- Coverage 81.14% 81.05% -0.10%
==========================================
Files 1834 1836 +2
Lines 254891 254959 +68
Branches 3177 3179 +2
==========================================
- Hits 206823 206647 -176
- Misses 47246 47488 +242
- Partials 822 824 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nameexhaustion
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
orlp and
ritchie46
as code owners
nameexhaustion
commented
May 6, 2026
| let IR::ExtContext { schema, .. } = storage.get(key) else { | ||
| break 'patch_ext_context; | ||
| }; | ||
| IR::ExtContext { schema, .. } => { |
Collaborator
Author
There was a problem hiding this comment.
extcontext branch is unchanged
Contributor
|
The uncompressed lib size after this PR is 61.3398 MB. |
Contributor
|
The uncompressed lib size after this PR is 60.8103 MB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the default behavior of strict horizontal concat w/ projection pushdown to before #25371. That is, we will always project at least 1 column from each input.
For users that would like to allow pruning of hconcat inputs in projection pushdown (thereby potentially discarding shape errors), an env var
POLARS_PROJECTION_PUSHDOWN_PRUNE_STRICT_HCONCAT_INPUTScan be set.