Skip to content

refactor: Re-work shuffle parameter for sample()#27460

Open
Kevin-Patyk wants to merge 5 commits intopola-rs:mainfrom
Kevin-Patyk:refactor/rework_shuffle_parameter
Open

refactor: Re-work shuffle parameter for sample()#27460
Kevin-Patyk wants to merge 5 commits intopola-rs:mainfrom
Kevin-Patyk:refactor/rework_shuffle_parameter

Conversation

@Kevin-Patyk
Copy link
Copy Markdown
Contributor

Resolves #23557.

🤖 Claude Sonnet 4.6 for navigating the codebase.

@github-actions github-actions Bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Apr 30, 2026
@github-actions github-actions Bot added the changes-dsl Do not merge if this label is present and red. label Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.14%. Comparing base (1156024) to head (d022a0b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/chunked_array/random.rs 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #27460   +/-   ##
=======================================
  Coverage   81.14%   81.14%           
=======================================
  Files        1834     1834           
  Lines      254891   254897    +6     
  Branches     3177     3177           
=======================================
+ Hits       206823   206837   +14     
+ Misses      47246    47238    -8     
  Partials      822      822           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes-dsl Do not merge if this label is present and red. internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-work shuffle parameter for sample()

1 participant