feat: Use true division for the / operator in Polars SQL#27391
Open
Kevin-Patyk wants to merge 7 commits intopola-rs:mainfrom
Open
feat: Use true division for the / operator in Polars SQL#27391Kevin-Patyk wants to merge 7 commits intopola-rs:mainfrom
/ operator in Polars SQL#27391Kevin-Patyk wants to merge 7 commits intopola-rs:mainfrom
Conversation
Kevin-Patyk
requested review from
alexander-beedie,
c-peters,
orlp and
ritchie46
as code owners
Kevin-Patyk
changed the title
/ operator in SQL/ operator in SQL
Kevin-Patyk
changed the title
/ operator in SQL/ operator in Polars SQL
github-actions
Bot
added
A-sql
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27391 +/- ##
==========================================
- Coverage 81.14% 80.45% -0.69%
==========================================
Files 1834 1834
Lines 254891 254894 +3
Branches 3177 3177
==========================================
- Hits 206823 205076 -1747
- Misses 47246 48996 +1750
Partials 822 822 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
As a random thought, @alexander-beedie do you think maybe we should add a warning that this behaviour changed for the end user? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #25396.
I saw you self-assigned @alexander-beedie, but figured I would give it a stab since it's been awhile. I hope that's okay 😃!
🤖 Claude Sonnet 4.6 for navigating and explaining existing code.