Skip to content

fix: Default engine as streaming for collect_batches #26932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritchie46 merged 5 commits into from
Mar 16, 2026
Merged

fix: Default engine as streaming for collect_batches #26932

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0cba00b
c
nameexhaustion Mar 16, 2026
e2a3c15
c
nameexhaustion Mar 16, 2026
ae8826c
this way
nameexhaustion Mar 16, 2026
9529e19
c
nameexhaustion Mar 16, 2026
983ec99
c
nameexhaustion Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions py-polars/src/polars/lazyframe/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4271,6 +4271,7 @@ def collect_batches(
>>> for df in lf.collect_batches():
... print(df) # doctest: +SKIP
"""
engine = "streaming" if engine == "auto" else _select_engine(engine)
Copy link
Copy Markdown
Member

@ritchie46 ritchie46 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_select_engine should go first as that check engine affinity.`

        engine = _select_engine(engine)
        engine = "streaming" if engine == "auto" else engine


class CollectBatches:
def __init__(self, inner: Any) -> None:
Expand Down
Loading