Skip to content

refactor(rust): Move IO source metrics instrumentation to PolarsObjectStore#26414

Merged
ritchie46 merged 5 commits intomainfrom
nxs/io-source-metrics-2
Feb 9, 2026
Merged

refactor(rust): Move IO source metrics instrumentation to PolarsObjectStore#26414
ritchie46 merged 5 commits intomainfrom
nxs/io-source-metrics-2

Conversation

@nameexhaustion
Copy link
Copy Markdown
Collaborator

@nameexhaustion nameexhaustion commented Feb 4, 2026

This makes it so that IO sources that use DynByteSource::ObjectStore will automatically have IO recv stats recorded (currently used by Parquet & IPC).

@github-actions github-actions Bot added A-dtype-object Area: object data type internal An internal refactor or improvement rust Related to Rust Polars labels Feb 4, 2026
@nameexhaustion nameexhaustion force-pushed the nxs/io-source-metrics-2 branch from c35962f to b47337d Compare February 4, 2026 08:01
Base automatically changed from nxs/move-io-metrics to main February 4, 2026 15:16
@nameexhaustion nameexhaustion force-pushed the nxs/io-source-metrics-2 branch from b47337d to 38477fd Compare February 5, 2026 05:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.08%. Comparing base (8a81b0e) to head (c38646b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/cloud/polars_object_store.rs 93.75% 4 Missing ⚠️
...polars-stream/src/nodes/io_sources/ipc/metadata.rs 80.00% 1 Missing ⚠️
...eam/src/nodes/io_sources/parquet/metadata_utils.rs 80.00% 1 Missing ⚠️
...c/nodes/io_sources/parquet/row_group_data_fetch.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #26414   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files        1783     1783           
  Lines      243288   243275   -13     
  Branches     3074     3074           
=======================================
- Hits       197263   197256    -7     
+ Misses      45222    45216    -6     
  Partials      803      803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pola-rs pola-rs deleted a comment from github-actions Bot Feb 5, 2026
@pola-rs pola-rs deleted a comment from github-actions Bot Feb 5, 2026
@pola-rs pola-rs deleted a comment from github-actions Bot Feb 5, 2026
@nameexhaustion nameexhaustion marked this pull request as ready for review February 5, 2026 09:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

The uncompressed lib size after this PR is 51.4183 MB.

@ritchie46 ritchie46 merged commit 28b0440 into main Feb 9, 2026
23 checks passed
@ritchie46 ritchie46 deleted the nxs/io-source-metrics-2 branch February 9, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dtype-object Area: object data type internal An internal refactor or improvement rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants