refactor(rust): Move IO source metrics instrumentation to PolarsObjectStore#26414
Merged
refactor(rust): Move IO source metrics instrumentation to PolarsObjectStore#26414
PolarsObjectStore#26414Conversation
c35962f to
b47337d
Compare
b47337d to
38477fd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #26414 +/- ##
=======================================
Coverage 81.08% 81.08%
=======================================
Files 1783 1783
Lines 243288 243275 -13
Branches 3074 3074
=======================================
- Hits 197263 197256 -7
+ Misses 45222 45216 -6
Partials 803 803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
The uncompressed lib size after this PR is 51.4183 MB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that IO sources that use
DynByteSource::ObjectStorewill automatically have IO recv stats recorded (currently used by Parquet & IPC).