Skip to content

refactor: Turn pl.cumulative_eval into its own AExpr#22994

Merged
coastalwhite merged 8 commits intopola-rs:mainfrom
coastalwhite:refactor/cum-eval-aexpr
Jun 2, 2025
Merged

refactor: Turn pl.cumulative_eval into its own AExpr#22994
coastalwhite merged 8 commits intopola-rs:mainfrom
coastalwhite:refactor/cum-eval-aexpr

Conversation

@coastalwhite
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 28, 2025
@coastalwhite coastalwhite force-pushed the refactor/cum-eval-aexpr branch from aa00a84 to 4ec705a Compare May 30, 2025 07:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 72.35772% with 34 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (fb9a4e8) to head (3b4eb7c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/expressions/eval.rs 74.02% 20 Missing ⚠️
crates/polars-plan/src/dsl/expr/mod.rs 38.46% 8 Missing ⚠️
crates/polars-plan/src/dsl/format.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22994   +/-   ##
=======================================
  Coverage   80.41%   80.42%           
=======================================
  Files        1682     1680    -2     
  Lines      223305   223330   +25     
  Branches     2802     2802           
=======================================
+ Hits       179572   179612   +40     
+ Misses      43071    43056   -15     
  Partials      662      662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite force-pushed the refactor/cum-eval-aexpr branch from b63b89f to 7622e97 Compare June 2, 2025 11:24
@coastalwhite coastalwhite merged commit 4d79b02 into pola-rs:main Jun 2, 2025
29 checks passed
@coastalwhite coastalwhite deleted the refactor/cum-eval-aexpr branch June 2, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant