perf: Optimise low-level null scans and arg_max for bools (when chunked)#22897
Merged
orlp merged 2 commits intopola-rs:mainfrom May 23, 2025
Merged
perf: Optimise low-level null scans and arg_max for bools (when chunked)#22897orlp merged 2 commits intopola-rs:mainfrom
null scans and arg_max for bools (when chunked)#22897orlp merged 2 commits intopola-rs:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22897 +/- ##
==========================================
- Coverage 80.70% 80.63% -0.08%
==========================================
Files 1671 1671
Lines 221173 221446 +273
Branches 2792 2791 -1
==========================================
+ Hits 178502 178563 +61
- Misses 42001 42218 +217
+ Partials 670 665 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orlp
requested changes
May 23, 2025
orlp
approved these changes
May 23, 2025
Member
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimisations
Spotted some nice speedups for the lower-level
first_not_nullandlast_non_nullvalidity/bitmap scans while working on #22880; breaking them out as a standalone PR so we can take advantage while deciding on a better API for that one.So, switching out the following offset calculations...
...for (more or less)...
...and adjusting the surrounding code slightly allows us to get the required result directly from the validity bitmap without mediating via
BitMaskandnth_set_bit_idx.Speedup:
build-dist-release) 🚀Also:
arg_max_boolto handle "n" chunks..index_of(None), and an associated small parametric test to improve edge-case coverage.