feat: Reinterpret binary data to fixed size numerical array#22840
Merged
nameexhaustion merged 84 commits intopola-rs:mainfrom Aug 1, 2025
Merged
feat: Reinterpret binary data to fixed size numerical array#22840nameexhaustion merged 84 commits intopola-rs:mainfrom
nameexhaustion merged 84 commits intopola-rs:mainfrom
Conversation
…into add-binary-as-numerical-array
itamarst
commented
May 20, 2025
Contributor
Author
|
Before I submit this for review I am going to:
|
itamarst
commented
May 20, 2025
itamarst
commented
May 20, 2025
itamarst
commented
May 20, 2025
itamarst
commented
May 20, 2025
itamarst
commented
May 20, 2025
itamarst
commented
May 20, 2025
itamarst
commented
May 20, 2025
itamarst
commented
May 20, 2025
itamarst
commented
May 20, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22840 +/- ##
==========================================
- Coverage 81.57% 81.42% -0.16%
==========================================
Files 1634 1641 +7
Lines 221194 222455 +1261
Branches 2813 2835 +22
==========================================
+ Hits 180443 181137 +694
- Misses 40060 40619 +559
- Partials 691 699 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
itamarst
commented
May 20, 2025
Contributor
Author
|
Back to you @nameexhaustion |
Contributor
Author
|
@nameexhaustion done |
Collaborator
|
It looks good, but let's take some steps to ensure safety. |
Contributor
Author
|
@nameexhaustion back to you. Also added a couple of extra tests. |
Contributor
Author
|
@nameexhaustion Done. |
nameexhaustion
approved these changes
Jul 18, 2025
Washiil
pushed a commit
to Washiil/polars
that referenced
this pull request
Aug 2, 2025
…22840) Co-authored-by: Jakub Filipek <[email protected]> Co-authored-by: Itamar Turner-Trauring <[email protected]> Co-authored-by: nameexhaustion <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22126
An updated version on code in #20456, by @balbok0, who did the initial implementation that got this working, so the bulk of the work.