feat: Add per partition sort and finish callback to sinks#22789
Merged
coastalwhite merged 13 commits intopola-rs:mainfrom May 23, 2025
Merged
feat: Add per partition sort and finish callback to sinks#22789coastalwhite merged 13 commits intopola-rs:mainfrom
coastalwhite merged 13 commits intopola-rs:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22789 +/- ##
========================================
Coverage 80.69% 80.69%
========================================
Files 1671 1672 +1
Lines 221440 221883 +443
Branches 2791 2798 +7
========================================
+ Hits 178682 179051 +369
- Misses 42093 42165 +72
- Partials 665 667 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
65940cb to
7a8700a
Compare
564d5c7 to
5f033bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 2 items to partition sinks
per_partition_sort_bywhich sorts a partition before writing by certain expressionsfinish_callbackwhich gets called with information about all the written files in the partitionThese are needed for better Iceberg support.