depr(python): Deprecate allow_missing_columns in scan_parquet in favor of missing_columns#22784
Merged
ritchie46 merged 2 commits intopola-rs:mainfrom May 27, 2025
Merged
Conversation
missing_columns parameter and deprecate allow_missing_columns in scan_parquetallow_missing_columns in scan_parquet in favor of missing_columns
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22784 +/- ##
==========================================
- Coverage 80.63% 80.63% -0.01%
==========================================
Files 1677 1677
Lines 222209 222226 +17
Branches 2801 2803 +2
==========================================
+ Hits 179178 179190 +12
- Misses 42364 42367 +3
- Partials 667 669 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
20c0920 to
e155a40
Compare
nameexhaustion
commented
May 22, 2025
| .extract::<PyBackedStr>()? | ||
| { | ||
| "ignore" => ExtraColumnsPolicy::Ignore, | ||
| "raise" => ExtraColumnsPolicy::Raise, |
Collaborator
Author
There was a problem hiding this comment.
Parameter parsing will be done on the Rust-side in PyScanOptions
3f8554c to
4e3e602
Compare
4e3e602 to
18abc1a
Compare
ritchie46
approved these changes
May 27, 2025
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow_missing_columns: boolin favor ofmissing_columns: Literal["insert", "raise"]#21997extra_columnsparameter toscan_parquet#22699