Skip to content

depr(python): Deprecate allow_missing_columns in scan_parquet in favor of missing_columns#22784

Merged
ritchie46 merged 2 commits intopola-rs:mainfrom
nameexhaustion:deprecate-allow-missing-columns
May 27, 2025
Merged

depr(python): Deprecate allow_missing_columns in scan_parquet in favor of missing_columns#22784
ritchie46 merged 2 commits intopola-rs:mainfrom
nameexhaustion:deprecate-allow-missing-columns

Conversation

@nameexhaustion
Copy link
Copy Markdown
Collaborator

@nameexhaustion nameexhaustion commented May 16, 2025

@github-actions github-actions Bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels May 16, 2025
@nameexhaustion nameexhaustion changed the title depr(python): Add missing_columns parameter and deprecate allow_missing_columns in scan_parquet depr(python): Deprecate allow_missing_columns in scan_parquet in favor of missing_columns May 16, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (5cec049) to head (e5c6d10).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/io/mod.rs 69.23% 4 Missing ⚠️
py-polars/polars/io/parquet/functions.py 57.14% 2 Missing and 1 partial ⚠️
crates/polars-io/src/parquet/read/reader.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22784      +/-   ##
==========================================
- Coverage   80.63%   80.63%   -0.01%     
==========================================
  Files        1677     1677              
  Lines      222209   222226      +17     
  Branches     2801     2803       +2     
==========================================
+ Hits       179178   179190      +12     
- Misses      42364    42367       +3     
- Partials      667      669       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nameexhaustion nameexhaustion force-pushed the deprecate-allow-missing-columns branch 2 times, most recently from 20c0920 to e155a40 Compare May 22, 2025 11:13
.extract::<PyBackedStr>()?
{
"ignore" => ExtraColumnsPolicy::Ignore,
"raise" => ExtraColumnsPolicy::Raise,
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter parsing will be done on the Rust-side in PyScanOptions

@nameexhaustion nameexhaustion added the blocked Cannot be worked on due to external dependencies, or significant new internal features needed first label May 22, 2025
@nameexhaustion nameexhaustion force-pushed the deprecate-allow-missing-columns branch from 3f8554c to 4e3e602 Compare May 26, 2025 10:20
@nameexhaustion nameexhaustion force-pushed the deprecate-allow-missing-columns branch from 4e3e602 to 18abc1a Compare May 27, 2025 05:57
@nameexhaustion nameexhaustion removed the blocked Cannot be worked on due to external dependencies, or significant new internal features needed first label May 27, 2025
@nameexhaustion nameexhaustion marked this pull request as ready for review May 27, 2025 07:45
@ritchie46 ritchie46 merged commit 367dc90 into pola-rs:main May 27, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Add a deprecation warning to outdated functionality python Related to Python Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants