hack: 😴 sleep enough for cli debug subcommands to broadcast#954
Merged
hack: 😴 sleep enough for cli debug subcommands to broadcast#954
Conversation
Olshansk
approved these changes
Jul 31, 2023
Collaborator
Olshansk
left a comment
Olshansk
left a comment
There was a problem hiding this comment.
@0xBigBoss I have a similar hack for this in #874, so would appreciate if you review that as well.
Feel free to merge this in to unblock main in the meantime.
Co-authored-by: Daniel Olshansky <[email protected]>
red-0ne
pushed a commit
that referenced
this pull request
Aug 2, 2023
Co-authored-by: Daniel Olshansky <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running commands like
p1 dui TriggerNextView, seems the program exits faster than the p2p module can broadcast. This PR introduces a magic number to give the p2p module enough time to broadcast the debug messages when run as a subcommand.This is working for my e2e testing for now.