[Persistence] Adds node subcommand to CLI#935
Merged
Conversation
dylanlott
force-pushed
the
persistence/save-cli
branch
from
00d8ca9 to
c38976b
Compare
dylanlott
changed the base branch from
persistence/save-load
to
persistence/savepoints-initial
reviewpad
bot
added
small
Olshansk
requested changes
Jul 24, 2023
Collaborator
Olshansk
left a comment
Olshansk
left a comment
There was a problem hiding this comment.
Changes lgtm. Any reason we can't base this against main instead of persistence/savepoints-initial?
dylanlott
force-pushed
the
persistence/save-cli
branch
from
c38976b to
0345dfc
Compare
Contributor
Author
Absolutely none 😄 I had just been on |
h5law
approved these changes
Jul 25, 2023
Contributor
h5law
left a comment
h5law
left a comment
There was a problem hiding this comment.
Changes are small looks good to me, unsure on the linter error but once thats figured out/fixed lets 
Olshansk
approved these changes
Jul 25, 2023
dylanlott
force-pushed
the
persistence/save-cli
branch
from
0345dfc to
f7242eb
Compare
red-0ne
pushed a commit
that referenced
this pull request
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the first step of the CLI harness for save and load E2E testing. This PR is the first of a series and will be followed by additional PRs adding the actual sub-command logic and execution.
nodekeyword was chosen contrary to #566 as per the Discussion in Discord.Issue
Relates to a series of changes to address #566
Type of change
Please mark the relevant option(s):
List of changes
nodesub-command to the app CLI.Testing
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)