Skip to content

Ibc/client semantics interface only#925

Closed
Olshansk wants to merge 27 commits intomainfrom
ibc/client-semantics-interface-only
Closed

Ibc/client semantics interface only#925
Olshansk wants to merge 27 commits intomainfrom
ibc/client-semantics-interface-only

Conversation

@Olshansk
Copy link
Collaborator

@Olshansk Olshansk commented Jul 21, 2023

Description

Summary generated by Reviewpad on 21 Jul 23 19:51 UTC

This pull request includes multiple file diffs. Here is a summary of the changes:

  1. The file "bus_module.go" has a new method "GetClientManager()" added to the interface "Bus".

  2. The file "proofs.proto" contains the definition of message types and enums related to proof specifications and operations. These types are used to verify the integrity and validity of data.

  3. The file "proofs.go" in the "ibc/types" package converts types from the IBC protocol to types used in the ICS23 library for cryptographic proofs.

  4. The file "ibc_client_module.go" in the "shared/modules" directory manages IBC clients by defining an interface and related types and functions.

  5. The file contains the definition of the "IBCModule" and "IBCHandler" interfaces, used in the Inter-Blockchain Communication protocol.

  6. There is a file diff that introduces new error codes, updates existing error codes, and adds a new error function.

  7. A new file "ibc_events.go" is added to the "shared/core/types" package, which includes a function for creating attributes.

  8. The file "ibc_events.proto" has changes, specifically in the "Attribute" and "IBCEvent" message definitions.

  9. Changes to the "IBCHostSubmodule" interface in the "ibc_host_module.go" file, including the removal of the "IBCHandler" interface.

  10. Changes to the build process, including the addition of OS-specific commands, new targets, and modifications to existing targets.

  11. Modifications to the "PersistenceReadContext" interface related to adding a new function and changing the type of a parameter.

  12. Changes to the import paths and type names in the "ibc_event_module.go" file.

  13. The addition of a new file "wasm.proto" that defines protocol buffer messages for a Wasm light client.

  14. The addition of a new file "pocket.proto" that defines protocol buffer messages for the Pocket client in the IBC(Client) module.

Please review these changes and ensure they meet the desired outcomes. Let me know if you need more details or specific clarifications on any of the file diffs.

Issue

Fixes #<issue_number>

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 21, 2023
@h5law
Copy link
Contributor

h5law commented Jul 28, 2023

PR not needed was a test

@h5law h5law closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large Pull request is large waiting-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants