[IBC] Make the IBC Host a submodule with access to the bus

[h5law]

Description

Summary generated by Reviewpad on 13 Jul 23 10:41 UTC

This pull request includes several changes across multiple files. Here is a summary of the changes:

1. In the file ibc/handle_message_test.go, the file was renamed to ibc/ibc_msg_mempool_test.go with a similarity index of 85%.
2. In the same file, the imports were modified, and the strings package was added.
3. The test function TestHandleMessage_ErrorAlreadyInMempool was renamed to TestEmitMessage_MessageAddedToLocalMempool. Some code within the renamed test function was also modified, including changes in the preparation of test data and the addition of a transaction to the mempool.
4. The test function TestHandleMessage_BasicValidation_Message was renamed to TestIBCMessage_BasicValidation_Message.
5. The test function TestHandleMessage_BasicValidation_Transaction was renamed to TestIBCMessage_BasicValidation_Transaction.
6. A new test function TestHandleMessage_ErrorAlreadyInMempool was added to check for the error of having a duplicate transaction in the mempool.
7. A new test function TestHandleMessage_ErrorAlreadyCommitted was added to check for the error of having an already committed transaction.
8. The test function TestHandleMessage_GetIndexedMessage was modified to include changes in the preparation of the environment.
9. The test function TestHandleMessage_AddToMempool was removed.

Additionally, other files such as treestore_module.go, emitter.go, submodule.go, config.validator4.json, persistence/ibc.go, defaults.go, bus_module.go, ibc_store_module.go, bulk_store_cache.go, ibc_host_module.go, config.validator4.json, persistence/test/benchmark_state_test.go, p2p/README.md, runtime/manager_test.go, shared/node.go, persistence/test/manager_test.go, shared/modules/bulk_store_cache.go, ibc.go, shared/node.go, ics24.md, main_test.go have also been modified.

Please let me know if you need more information or details about any specific change.

Issue

Fixes #854

Type of change

Please mark the relevant option(s):

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Major breaking change
• Documentation
• Other

List of changes

• Move IBC host into its own submodule
• Enable local ProvableStore instances to emit events to alter the IBC state tree

Testing

• make develop_test; if any code changes were made
• make test_e2e on k8s LocalNet; if any code changes were made
• e2e-devnet-test passes tests on DevNet; if any code was changed
• Docker Compose LocalNet; if any major functionality was changed or introduced
• k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
• I have tested my changes using the available tooling
• I have updated the corresponding CHANGELOG

If Applicable Checklist

• I have updated the corresponding README(s); local and/or global
• I have added tests that prove my fix is effective or that my feature works
• I have added, or updated, mermaid.js diagrams in the corresponding README(s)
• I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

[h5law]

@Olshansk added tests to cover the flushing and pruning works on new height events

[Olshansk]

@h5law I have some questions around the test. It might just be me but its not completely clear how the test guarantees what we expect.

@bryanchriswhite Do you mind taking a look at ibc/ibc_handle_event_test.go as well

[Olshansk]

A couple more nits.

PTAL at #868 (comment) as well

[Olshansk]

@h5law Please be cognizant of the branches (based branches, merge order etc...), since I just approved two of them.

I suggest:

1. Merge the base to main
2. Merge this one with main
3. Push this one up + update base to main
4. Sanity check this PR is good
5. Merge this into main

Other than that, 🚢