Skip to content

[KEYBASE] Add improve comment on keybase config#665

Merged
0xBigBoss merged 2 commits intomainfrom
0xbigboss/comment-on-626
Apr 11, 2023
Merged

[KEYBASE] Add improve comment on keybase config#665
0xBigBoss merged 2 commits intomainfrom
0xbigboss/comment-on-626

Conversation

@0xBigBoss
Copy link
Contributor

Description

See #626

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

@0xBigBoss 0xBigBoss added documentation Improvements or additions to documentation code health Nice to have code improvement infra Core infrastructure - not protocol related labels Apr 11, 2023
@0xBigBoss 0xBigBoss requested a review from Olshansk April 11, 2023 01:14
@0xBigBoss 0xBigBoss self-assigned this Apr 11, 2023
@cr-gpt
Copy link

cr-gpt bot commented Apr 11, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

@reviewpad
Copy link

reviewpad bot commented Apr 11, 2023

AI-Generated Summary: This pull request makes a small change to the runtime/configs/config.go file, improving the comment on the KeybaseConfig field within the Config struct. It provides some context on the rationale behind the current proto design and mentions a related issue (#626) as well as proposed improvements that were not implemented due to limitations in the Viper library.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog validation failed with the following output:
Missing changelog in module: runtime/

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

@cr-gpt
Copy link

cr-gpt bot commented Apr 11, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

@reviewpad
Copy link

reviewpad bot commented Apr 11, 2023

AI-Generated Summary: This pull request consists of two updates:

  1. Improves the comment on the KeybaseConfig in the config.go file, providing more context regarding the design of the keybase proto.
  2. Updates the CHANGELOG.md file to include a new version entry, 0.0.0.31, which details the added comment about KeybaseConfig proto design.

@github-actions github-actions bot dismissed their stale review April 11, 2023 21:30

The check succeeded, dismissing the review comment.

@0xBigBoss 0xBigBoss merged commit 29929cd into main Apr 11, 2023
bryanchriswhite added a commit that referenced this pull request Apr 12, 2023
…p-modules

* pokt/main:
  update pocket repo read.me (#667)
  Update reviewpad.yml
  [KEYBASE] Add improve comment on keybase config (#665)
  [E2E] Chore: Doc updates (#663)
  [E2E] Adds staking, unstaking, and sending tests (#653)
  [Utility][RPC][CLI] Querying governance parameters (Issue #619) (#622)
  [Persistence][Utility] Separate all CreateAndApply functions into more functional components - Issue #508 (#652)
  [Persistence][Utility] Pools Address hack removal + state accessor fix for params and flags (#654)
  [PERSISTENCE] SavePoints and Rollbacks design document (Issue #493) (#533)
  Update reviewpad.yml
  Added ChatGPT-CodeReview workflow (#649)
  Update reviewpad.yml
  Added default reviewpad.yml file (#648)
  [DevNet] tweaks for remote environments (#601)
  [Documentation] Swap validator and non-validator triggers when finished synching (#646)
  [Consensus] Configuration entry point state sync (#528)
bryanchriswhite added a commit that referenced this pull request Apr 12, 2023
…p-modules

* pokt/main:
  update pocket repo read.me (#667)
  Update reviewpad.yml
  [KEYBASE] Add improve comment on keybase config (#665)
  [E2E] Chore: Doc updates (#663)
  [E2E] Adds staking, unstaking, and sending tests (#653)
  [Utility][RPC][CLI] Querying governance parameters (Issue #619) (#622)
  [Persistence][Utility] Separate all CreateAndApply functions into more functional components - Issue #508 (#652)
  [Persistence][Utility] Pools Address hack removal + state accessor fix for params and flags (#654)
  [PERSISTENCE] SavePoints and Rollbacks design document (Issue #493) (#533)
  Update reviewpad.yml
  Added ChatGPT-CodeReview workflow (#649)
  Update reviewpad.yml
  Added default reviewpad.yml file (#648)
  [DevNet] tweaks for remote environments (#601)
  [Documentation] Swap validator and non-validator triggers when finished synching (#646)
  [Consensus] Configuration entry point state sync (#528)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health Nice to have code improvement documentation Improvements or additions to documentation infra Core infrastructure - not protocol related waiting-for-review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants