Merged
Conversation
4f9f13f to
d4b0c6e
Compare
6b2d221 to
3ee63c9
Compare
Collaborator
Author
|
This PR is based off of the |
d4b0c6e to
6074b77
Compare
3ee63c9 to
88097c3
Compare
deblasis
reviewed
Feb 28, 2023
Comment on lines
7
to
+11
| "github.com/manifoldco/promptui" | ||
| "github.com/spf13/cobra" | ||
| "google.golang.org/protobuf/types/known/anypb" | ||
|
|
||
| "github.com/pokt-network/pocket/libp2p" |
Contributor
There was a problem hiding this comment.
Not actionable: 💯 I like this. I guess we should start doing this across the board and separate external/internal imports. Maybe we should create an issue to tackle it in one scoop also to create team awareness since it's gonna be discussed at least once in standup at some point.
Probably too boring to be outsourced to the community 🤔 and however low priority, something to do to kill boredom with more... boredom 😆. Wdyt?
Closed
6 tasks
8561324 to
42f8e74
Compare
88097c3 to
723453d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is another (last, probably) in a series of PRs split out from #500. Here we finally enable support for use of the new libp2p module (and dependent packages) by considering the config changes made in #535 in the node and debug CLI.
Issue
#347
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_testREADMERequired Checklist
If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)