Skip to content

[Consensus] State sync server to advertise blocks#431

Merged
gokutheengineer merged 179 commits intomainfrom
issue/409-state-sync-server-to-advertise-blocks
Feb 9, 2023
Merged

[Consensus] State sync server to advertise blocks#431
gokutheengineer merged 179 commits intomainfrom
issue/409-state-sync-server-to-advertise-blocks

Conversation

@gokutheengineer
Copy link
Contributor

@gokutheengineer gokutheengineer commented Jan 6, 2023

Description

This PR aims to implement state sync server module.

Issue

Fixes #409

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Add state_sync submodule to Consensus Module
  • Implement state sync server to advertise blocks and metadata
  • Create new state_snyc_handler.go source file that handles stateSyncMessages sent to the consensus module
  • Write state sync server tests, update hotstuff test
  • Add ConsensusStateSync interface to the shared module

Testing

  • make develop_test
  • LocalNet w/ all of the steps outlined in the README

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@gokutheengineer gokutheengineer self-assigned this Jan 6, 2023
@gokutheengineer gokutheengineer added the consensus Consensus specific changes label Jan 6, 2023
@gokutheengineer gokutheengineer marked this pull request as draft January 6, 2023 20:21
Copy link
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gokutheengineer I did an EXTREMELY quick review, but it's going in the right direction!

@gokutheengineer gokutheengineer changed the title Issue/409 state sync server to advertise blocks [Consensus] Issue/409 state sync server to advertise blocks Jan 9, 2023
@gokutheengineer gokutheengineer changed the title [Consensus] Issue/409 state sync server to advertise blocks [Consensus] State sync server to advertise blocks Jan 9, 2023
@Olshansk
Copy link
Collaborator

Olshansk commented Jan 9, 2023

@gokutheengineer Great progress on this! Lmk when you need me to take a deeper look

Copy link
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round and we should be able to get this in tomorrow first thing.

Just some comments around the integration with the logging PR primarily

gokutheengineer and others added 10 commits February 9, 2023 10:33
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Copy link
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gokutheengineer I made a few last in-place suggestions, but otherwise LGTM.

We could even show this in an internal protocol hour next week (the in-progress work) if you're up for it?

gokutheengineer and others added 2 commits February 9, 2023 23:35
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer
Copy link
Contributor Author

@gokutheengineer I made a few last in-place suggestions, but otherwise LGTM.

We could even show this in an internal protocol hour next week (the in-progress work) if you're up for it?

Sure, I think it is a good idea.

@gokutheengineer gokutheengineer merged commit e32df6b into main Feb 9, 2023
@Olshansk Olshansk deleted the issue/409-state-sync-server-to-advertise-blocks branch June 2, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consensus Consensus specific changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Consensus] State Sync - Server to Advertise Blocks

2 participants