[Stale] [Telemetry] Introduce a singleton std logger to the codebase to unify logs#162
Closed
[Stale] [Telemetry] Introduce a singleton std logger to the codebase to unify logs#162
Conversation
2 tasks
25f2d8d to
71156f7
Compare
71156f7 to
680ef51
Compare
7 tasks
Collaborator
|
Going to close this out since we are unlikely to iterate on top of this PR specifically but planning on using it as a reference for when we standardize logging. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to achieve the goals of logging for the telemetry milestone, we will unify logging across the codebase by using a singleton logger. This logger will be imported directly in the shared scope of modules, but will also be used in the modules' scope through the telemetry module.
The origin document can be found here: #164
Changes
Loggerinterface undershared/loggingLoggerinterface while usinglog.Loggeras the log engine andos.Stdoutas the output.The log line format is as follows:
Example:
Please lookup the available levels and namespaces in
shared/logging/types.goOwners
@derrandz