[P2P] Replace addressing via ServiceUrl/GenericParam with P2P routing

[deblasis]

Objective

Offload the business logic of message routing entirely to the P2P module

We currently connect nodes using the endpoint (host & port) captured in an actor's ServiceUrl, which is retrieved/set using the GenericParam field in the proto. See #313 for the source of this naming and grep for generic_param in the codebase to find its uses. By default, we configure nodes to list on port 8080.

Hosts, ports and endpoint logic/complexity should be encapsulated inside the P2P module. No other modules, or configurations files (e.g. geneis et al) should have any understanding of network routing other than cryptographic identities.

Origin Document

If you are taking on this task, make sure to read this discussion first: #403 (comment)

Goals

• Encapsulate network routing business logic to the P2P module
• Use cryptographic identities only for messaging, communication and configuration outside the P2P module
• Set up the codebase for integration with libp2p

Deliverable

• Address TODO (#426): in the codebase
• Refactor related code accordingly. Including but not limited to:
  • Removing exposed P2P business logic (eg: ActorToNetworkPeer)

Non-goals / Non-deliverables

• [P2P] Peer Discovery - LibP2P - Consolidate Node/Peer ID with LibP2P Peer ID ([P2P][LibP2P][SPIKE] Consolidate and Refactor Node Identity #348)
• [Utility] Design & implement a better approach to GenericParam / ActorSpecificParam ([Utility] Design & implement a better approach to GenericParam / ActorSpecificParam #313)

General issue deliverables

• Update the appropriate CHANGELOG(s)
• Update any relevant local/global README(s)
• Update relevant source code tree explanations
• Add or update any relevant or supporting mermaid diagrams

Testing Methodology

• Task specific tests or benchmarks: make ...
• New tests or benchmarks: make ...
• All tests: make test_all
• LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

---

Creator: @deblasis
Co-Owners: @Olshansk

[Olshansk]

@deblasis Made a few edits to the description so the scope is pretty clearly defined now.

[deblasis]

Thank you @Olshansk 🙏

[jessicadaugherty]

@jessicadaugherty and @bryanchriswhite investigate how much of this was accomplished through P2P refacotring and update or delete accordingly

[Olshansk]

@bryanchriswhite Can you review this ticket after merging in all the ongoing work, I think it'll be either resolved or no longer relevant.

[bryanchriswhite]

All deliverables have been completed over the course of libp2p integration and refactoring.