-
Notifications
You must be signed in to change notification settings - Fork 33
Closed
Labels
coreCore infrastructure - protocol relatedCore infrastructure - protocol relatedp2pP2P specific changesP2P specific changesutilityUtility specific changesUtility specific changes
Milestone
Description
Objective
Make the Mempool interface and implementation a common high-level type that can be reused across different modules
Origin Document
This discussion in #374: #374 (comment)
Goals
- Create a Mempool type that other modules can easily import & reuse
- Clean up the code so all the modules are using the same mempool implementation
Deliverable
- Create a shared mempool object based on
utility/types/Mempoolintoshared/mempool - Import and use
shared/mempoolin the utility module - Import and use
shared/mempoolin the p2p module - Add a couple mempool specific tests
- In
utility/test/module_test.go:TODO(#388): Expose aGetMempoolfunction inutility_moduleso we can remove this reflection.
Non-goals / Non-deliverables
- Modify existing business logic
General issue deliverables
- Update the appropriate CHANGELOG(s)
- Update any relevant local/global README(s)
- Update relevant source code tree explanations
- Add or update any relevant or supporting mermaid diagrams
Testing Methodology
- **Mempool tests **:
make test_mempool - All tests:
make test_all - LocalNet: verify a
LocalNetis still functioning correctly by following the instructions at docs/development/README.md
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
coreCore infrastructure - protocol relatedCore infrastructure - protocol relatedp2pP2P specific changesP2P specific changesutilityUtility specific changesUtility specific changes
Type
Projects
Status
Done
