This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Add scripts for the generation of keyboard switch footprints#605
Open
perigoso wants to merge 2 commits intopointhi:masterfrom
perigoso:keyboard_switch_scripts
Open
Add scripts for the generation of keyboard switch footprints#605perigoso wants to merge 2 commits intopointhi:masterfrom perigoso:keyboard_switch_scripts
perigoso wants to merge 2 commits intopointhi:masterfrom
perigoso:keyboard_switch_scripts
Conversation
|
Code Climate has analyzed commit 16e44b3 and detected 0 issues on this pull request. View more on Code Climate. |
Author
|
Detected Issues to be resolved before merge:
|
Signed-off-by: gimbas <[email protected]>
Signed-off-by: perigoso <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These scripts generate footprints for common switches used in keyboard applications, they include user drawing to aid the layout.
I understand the scripts might not be in great shape, my python is rough. Open to some feedback.
There is an issue with these scripts (or KicadModTree itself) it can be visualized in the second picture, it seems the
offset=[x,y]seems to not be taken into account like it should inkicad_mod.append(Pad(number=2, type=Pad.TYPE_THT, shape=Pad.SHAPE_OVAL, at=[-3.81,-2.54], size=[4.46156,2.5], rotation=48, offset=[0.980778,0], drill=1.5, layers=['*.Cu', 'B.Mask']))any input?